diff for duplicates of <1198893469.4861.9.camel@localhost> diff --git a/a/1.txt b/N1/1.txt index 08ef890..3b57d9d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Fri, 2007-12-28 at 01:18 +0100, Simon Holm Thøgersen wrote: +On Fri, 2007-12-28 at 01:18 +0100, Simon Holm Thøgersen wrote: > > - while ((ctrl_inb(GDROM_ALTSTATUS_REG) & 0x80) && (time_before(jiffies, timeout))) > > + while (gdrom_is_busy() && (time_before(jiffies, timeout))) > You don't need those parentheses. @@ -54,7 +54,7 @@ index 59d26e0..ab95438 100644 +static bool gdrom_data_request(void) +{ -+ return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8; ++ return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8; +} + static void gdrom_wait_clrbusy(void) @@ -90,8 +90,8 @@ index 59d26e0..ab95438 100644 static int gdrom_mediachanged(struct cdrom_device_info *cd_info, int ignore) { /* check the sense key */ -- return ((ctrl_inb(GDROM_ERROR_REG) & 0xF0) = 0x60); -+ return (ctrl_inb(GDROM_ERROR_REG) & 0xF0) = 0x60; +- return ((ctrl_inb(GDROM_ERROR_REG) & 0xF0) == 0x60); ++ return (ctrl_inb(GDROM_ERROR_REG) & 0xF0) == 0x60; } /* reset the G1 bus */ diff --git a/a/content_digest b/N1/content_digest index 84174e1..d99777c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\01198801142.5354.67.camel@odie\0" "From\0Joe Perches <joe@perches.com>\0" "Subject\0Re: [PATCH] SH/Dreamcast - add support for GD-Rom device\0" - "Date\0Sat, 29 Dec 2007 01:57:49 +0000\0" + "Date\0Fri, 28 Dec 2007 17:57:49 -0800\0" "To\0Simon Holm Th\303\270gersen <odie@cs.aau.dk>\0" "Cc\0Adrian McMenamin <adrian@newgolddream.dyndns.info>" Paul Mundt <lethal@linux-sh.org> @@ -12,7 +12,7 @@ " linux-sh <linux-sh@vger.kernel.org>\0" "\00:1\0" "b\0" - "On Fri, 2007-12-28 at 01:18 +0100, Simon Holm Th\303\203\302\270gersen wrote:\n" + "On Fri, 2007-12-28 at 01:18 +0100, Simon Holm Th\303\270gersen wrote:\n" "> > -\twhile ((ctrl_inb(GDROM_ALTSTATUS_REG) & 0x80) && (time_before(jiffies, timeout)))\n" "> > +\twhile (gdrom_is_busy() && (time_before(jiffies, timeout)))\n" "> You don't need those parentheses.\n" @@ -68,7 +68,7 @@ " \n" "+static bool gdrom_data_request(void)\n" "+{\n" - "+\treturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8;\n" + "+\treturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8;\n" "+}\n" "+\n" " static void gdrom_wait_clrbusy(void)\n" @@ -104,8 +104,8 @@ " static int gdrom_mediachanged(struct cdrom_device_info *cd_info, int ignore)\n" " {\n" " \t/* check the sense key */\n" - "-\treturn ((ctrl_inb(GDROM_ERROR_REG) & 0xF0) = 0x60);\n" - "+\treturn (ctrl_inb(GDROM_ERROR_REG) & 0xF0) = 0x60;\n" + "-\treturn ((ctrl_inb(GDROM_ERROR_REG) & 0xF0) == 0x60);\n" + "+\treturn (ctrl_inb(GDROM_ERROR_REG) & 0xF0) == 0x60;\n" " }\n" " \n" " /* reset the G1 bus */\n" @@ -152,4 +152,4 @@ " \t\tctrl_outb(1, GDROM_DMA_STATUS_REG);\n" " \t\t/* 5 second error margin here seems more reasonable */" -0ac9d795ba0a2740c28e3157b30516bb0162d255457cef131d6d74eaf2d71031 +aa35c31a9b063d6f026f072b7ba881b89f98a3c214c12b00f50a6e3e1816e86a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.