From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAyMh-0001TS-7u for mharc-grub-devel@gnu.org; Fri, 04 Jan 2008 21:02:23 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAyMe-0001SM-Sx for grub-devel@gnu.org; Fri, 04 Jan 2008 21:02:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAyMd-0001R8-Dz for grub-devel@gnu.org; Fri, 04 Jan 2008 21:02:20 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAyMd-0001R0-7D for grub-devel@gnu.org; Fri, 04 Jan 2008 21:02:19 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JAyMc-0001Tv-Qo for grub-devel@gnu.org; Fri, 04 Jan 2008 21:02:18 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 04 Jan 2008 21:02:17 -0500 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 9D5F4618FE1 for ; Fri, 4 Jan 2008 21:02:17 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <200801050227.34479.okuji@enbug.org> References: <20071231031229.1ilqcnpcwkc0oww8@webmail.spamcop.net> <20080103121112.GB6169@thorin> <20080103102846.mhnl7v6xw4ksk48k@webmail.spamcop.net> <200801050227.34479.okuji@enbug.org> Content-Type: text/plain Date: Fri, 04 Jan 2008 21:02:17 -0500 Message-Id: <1199498537.25368.25.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 (2.12.2-2.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Testing on PowerMac G4 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2008 02:02:21 -0000 On Sat, 2008-01-05 at 02:27 +0100, Yoshinori K. Okuji wrote: > On Thursday 03 January 2008 16:28, Pavel Roskin wrote: > > >> Linux style description. The first line is the synopsis. If it > > >> doesn't fit 72 characters, the patch is a candidate for splitting. > > >> Then an empty line. Then a more detailed description of the patch, > > >> including the motivation behind the changes. The list of the affected > > >> files can be generated by the version control system. > > > > > > Looks good. But I guess you'll have to convince Marco and Okuji > > > about this :-) > > > > Sure, it's in my TODO list :) > > I do not think automatically generated logs can be as precise as being made by > human. > > Anyway, there is no reason that you shouldn't write a detailed description in > ChangeLog. Indeed, I myself sometimes do that, when I make a big change or > something hard to understand. We are talking about a changeset from 2007-02-21 (the earliest of them), where the ChangeLog entry has the usual "calculate this" and "rename this to that". It took me hours of experiments to figure out that the intention was to load the core image and the modules much lower in the memory. Sure, it looks trivial when explained. And by the way, a trivial change that doesn't modify anything as fundamental as memory layout could be described in very similar terms. There is no way to see how profound changes are and whether they are relevant to the observed problems. Detailed descriptions may be useful in many cases, but in my opinion, they should be secondary to high level descriptions. -- Regards, Pavel Roskin