All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roese <sr@denx.de>
Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers
Date: Sun, 06 Jan 2008 07:53:06 +1100	[thread overview]
Message-ID: <1199566386.7291.58.camel@pasglop> (raw)
In-Reply-To: <200801051338.17957.sr@denx.de>


On Sat, 2008-01-05 at 13:38 +0100, Stefan Roese wrote:
> On Saturday 05 January 2008, Benjamin Herrenschmidt wrote:
> > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote:
> > > Performance tests done by AMCC have shown that 256 buffer increase the
> > > performance of the Linux EMAC driver. So let's update the default
> > > values to match this setup.
> > >
> > > Signed-off-by: Stefan Roese <sr@denx.de>
> > > ---
> >
> > Do we have the numbers ? Did they also measure latency ?
> 
> I hoped this question would not come. ;) No, unfortunately I don't have any 
> numbers. Just the recommendation from AMCC to always use 256 buffers.

Ok. Well, it's just a .config option so I suppose the patch is fine. Can
you also update the defconfigs (at least for the recent AMCC boards) ?

Ben.

  reply	other threads:[~2008-01-05 20:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05  9:50 [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers Stefan Roese
2008-01-05  9:50 ` Stefan Roese
2008-01-05 10:19 ` Benjamin Herrenschmidt
2008-01-05 12:38   ` Stefan Roese
2008-01-05 20:53     ` Benjamin Herrenschmidt [this message]
2008-01-05 21:48       ` Josh Boyer
2008-01-05 21:48         ` Josh Boyer
2008-01-05 21:54         ` Benjamin Herrenschmidt
2008-01-05 21:54           ` Benjamin Herrenschmidt
2008-01-06  1:43           ` Josh Boyer
2008-01-06  1:43             ` Josh Boyer
2008-01-11 17:48     ` Eugene Surovegin
2008-01-11 22:10       ` Benjamin Herrenschmidt
2008-01-11 22:10         ` Benjamin Herrenschmidt
2008-01-12  7:26         ` Stefan Roese
2008-01-12  7:26           ` Stefan Roese
2008-01-12  7:57           ` Benjamin Herrenschmidt
2008-01-12  7:57             ` Benjamin Herrenschmidt
2008-01-12  9:08             ` Eugene Surovegin
2008-01-12  9:08               ` Eugene Surovegin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199566386.7291.58.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.