All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Barada <peterb@logicpd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mpc83xx: UEC: add support for Broadcom	BCM5481 Gigabit PHY
Date: Tue, 08 Jan 2008 16:18:43 -0500	[thread overview]
Message-ID: <1199827124.8303.6.camel@blackhole> (raw)
In-Reply-To: <20080108142906.d9f29ede.kim.phillips@freescale.com>

On Tue, 2008-01-08 at 14:29 -0600, Kim Phillips wrote:
> On Tue, 8 Jan 2008 21:41:09 +0300
> Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> 
> > On Tue, Jan 08, 2008 at 10:50:18AM -0600, Kim Phillips wrote:
> > > On Tue, 25 Dec 2007 20:01:26 +0300
> > > Anton Vorontsov <avorontsov@ru.mvista.com> wrote:
> > > 
> > > > This patch adds basic support for Broadcom BCM5481 PHY,
> > > > with the quirk needed for at least MPC8360E-RDK.
> > > 
> > > ?  the MPC8360E-RDK doesn't exist in the mainline tree.
> > 
> > Patch for the board support was sent at the same time. Though,
> > I'll resend it with few improvements.
> 
> ok, yes, I'm a bit behind in my emails still :(.
> 
> I took a brief look at it; while modding, can you please:
> 
> a. reorder your Makefile entry in alpha order (per WD), and add
> MAINTAINERS and MAKEALL entries.
> 
> b. move the non-board specific nand code out of the board directory and
> merge with drivers/mtd/nand (this should go through Stefan Roese).
> 
> c. turn off CONFIG_OF_HAS_BD_T and CONFIG_OF_HAS_UBOOT_ENV (unless you
> have a really good reason to keep them on).
> 
> d. remove references to OF_CPU, OF_SOC, OF_QE, OF_TBCLK, OF_STDOUT_PATH
> and use the new libfdt glue code.
> 
> thanks in advance.
> 
> > > > Quirk comes from MPC8360E-RDK BSP source, I think author is
> > > > Peter Barada <peterb@logicpd.com>, but I'm not sure.
> > > 
> > > solicit his signoff then?
> > 
> > Not an absolute necessity.
> > 
> ok, we'll see if Peter replies anyway.  Thanks for paying attention to
> this matter.

I the code to the Freescale BSP u-boot-1.1.3 code that added support for
the 8360EPB board.  Where is the patch you put together so I can look it
over?

> 
> Kim
-- 
Peter Barada <peterb@logicpd.com>

      reply	other threads:[~2008-01-08 21:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-25 17:01 [U-Boot-Users] [PATCH] mpc83xx: UEC: add support for Broadcom BCM5481 Gigabit PHY Anton Vorontsov
2008-01-08 16:50 ` Kim Phillips
2008-01-08 18:04   ` Ben Warren
2008-01-08 23:31     ` Kim Phillips
2008-01-08 18:41   ` Anton Vorontsov
2008-01-08 20:29     ` Kim Phillips
2008-01-08 21:18       ` Peter Barada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199827124.8303.6.camel@blackhole \
    --to=peterb@logicpd.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.