All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: Remove ifdef from step.c
Date: Wed, 09 Jan 2008 23:18:02 -0800	[thread overview]
Message-ID: <1199949482.19760.9.camel@brick> (raw)

Similar cleanup was done when unifying kprobes_32|64.c and
wrmsr() was chosen there over wrmsrl().

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Ingo, only chose this direction based on the kprobes.c unification.

 arch/x86/kernel/step.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/step.c b/arch/x86/kernel/step.c
index 21ea22f..d73c537 100644
--- a/arch/x86/kernel/step.c
+++ b/arch/x86/kernel/step.c
@@ -148,11 +148,7 @@ static void write_debugctlmsr(struct task_struct *child, unsigned long val)
 	if (child != current)
 		return;
 
-#ifdef CONFIG_X86_64
-	wrmsrl(MSR_IA32_DEBUGCTLMSR, val);
-#else
 	wrmsr(MSR_IA32_DEBUGCTLMSR, val, 0);
-#endif
 }
 
 /*
-- 
1.5.4.rc2.1164.g6451


             reply	other threads:[~2008-01-10  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10  7:18 Harvey Harrison [this message]
2008-01-10 12:40 ` [PATCH] x86: Remove ifdef from step.c Ingo Molnar
2008-01-10 19:29   ` Harvey Harrison
2008-01-10 19:40   ` [PATCH] x86: Use wrmsrl in kprobes.c, step.c Harvey Harrison
2008-01-10 19:49     ` H. Peter Anvin
2008-01-10 20:15       ` [PATCHv2] " Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199949482.19760.9.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.