From: Junxiao Shi <git@mail1.yoursunny.com>
To: dev@dpdk.org
Subject: [PATCH] net/memif: allow stopping and closing device
Date: Thu, 18 Nov 2021 17:33:46 +0000 [thread overview]
Message-ID: <119df28c7cc9d267@cs.arizona.edu> (raw)
Bugzilla ID: 888
Fixes: febc855b358e ("ethdev: forbid closing started device")
Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
---
drivers/net/memif/rte_eth_memif.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index 43d7378329..e3d523af57 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1260,6 +1260,13 @@ memif_dev_start(struct rte_eth_dev *dev)
return ret;
}
+static int
+memif_dev_stop(struct rte_eth_dev *dev)
+{
+ memif_disconnect(dev);
+ return 0;
+}
+
static int
memif_dev_close(struct rte_eth_dev *dev)
{
@@ -1268,7 +1275,6 @@ memif_dev_close(struct rte_eth_dev *dev)
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
memif_msg_enq_disconnect(pmd->cc, "Device closed", 0);
- memif_disconnect(dev);
for (i = 0; i < dev->data->nb_rx_queues; i++)
(*dev->dev_ops->rx_queue_release)(dev, i);
@@ -1276,8 +1282,6 @@ memif_dev_close(struct rte_eth_dev *dev)
(*dev->dev_ops->tx_queue_release)(dev, i);
memif_socket_remove_device(dev);
- } else {
- memif_disconnect(dev);
}
rte_free(dev->process_private);
@@ -1515,6 +1519,7 @@ memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid __rte_unused)
static const struct eth_dev_ops ops = {
.dev_start = memif_dev_start,
+ .dev_stop = memif_dev_stop,
.dev_close = memif_dev_close,
.dev_infos_get = memif_dev_info,
.dev_configure = memif_dev_configure,
--
2.17.1
next reply other threads:[~2021-11-18 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 17:33 Junxiao Shi [this message]
2021-11-24 11:02 ` [PATCH] net/memif: allow stopping and closing device Ferruh Yigit
2021-11-24 14:01 ` yoursunny
2021-11-24 14:43 ` Ferruh Yigit
2021-11-24 15:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119df28c7cc9d267@cs.arizona.edu \
--to=git@mail1.yoursunny.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.