From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Kamel Bouhara <kamel.bouhara@bootlin.com>,
Marco Felsch <kernel@pengutronix.de>,
Henrik Rydberg <rydberg@bitmath.org>,
Danilo Krummrich <dakr@redhat.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 3/4] dt-bindings: input: Add TouchNetix axiom touchscreen
Date: Thu, 29 May 2025 09:33:13 +0200 [thread overview]
Message-ID: <119eba0a-2c81-4232-8b20-acc0a0eea969@kernel.org> (raw)
In-Reply-To: <20250529-v6-10-topic-touchscreen-axiom-v2-3-a5edb105a600@pengutronix.de>
On 29/05/2025 00:08, Marco Felsch wrote:
> +maintainers:
> + - Marco Felsch <kernel@pengutronix.de>
> +
> +allOf:
> + - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> + - $ref: /schemas/input/input.yaml#
> +
> +properties:
> + compatible:
> + const: touchnetix,ax54a
> +
> + reg:
> + enum: [ 0x66, 0x67 ]
Isn't this the same address? You just added the write bit.
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> +
> + panel: true
So that was the reason of dropping tag?
https://lore.kernel.org/lkml/821ce1d4-bc15-4764-bbe0-315c57e8536e@linaro.org/
Anyway, drop the property. Redundant.
> +
> + vdda-supply:
> + description: Analog power supply regulator on VDDA pin
> +
> + vddi-supply:
> + description: I/O power supply regulator on VDDI pin
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-29 7:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 22:08 [PATCH v2 0/4] Input: Add support for TouchNetix aXiom touchscreen Marco Felsch
2025-05-28 22:08 ` [PATCH v2 1/4] firmware_loader: expand firmware error codes with skip error Marco Felsch
2025-06-05 1:58 ` Russ Weight
2025-06-27 17:28 ` Marco Felsch
2025-05-28 22:08 ` [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add TouchNetix AS Marco Felsch
2025-05-29 7:29 ` Krzysztof Kozlowski
2025-05-29 7:30 ` Krzysztof Kozlowski
2025-05-30 8:30 ` Marco Felsch
2025-05-28 22:08 ` [PATCH v2 3/4] dt-bindings: input: Add TouchNetix axiom touchscreen Marco Felsch
2025-05-29 7:33 ` Krzysztof Kozlowski [this message]
2025-05-30 8:45 ` Marco Felsch
2025-06-02 8:17 ` Krzysztof Kozlowski
2025-05-29 7:36 ` Krzysztof Kozlowski
2025-05-30 9:48 ` Marco Felsch
2025-05-28 22:08 ` [PATCH v2 4/4] Input: Add TouchNetix aXiom I2C Touchscreen support Marco Felsch
2025-05-29 4:40 ` Greg Kroah-Hartman
2025-05-30 9:40 ` Marco Felsch
2025-05-30 5:41 ` kernel test robot
2025-05-30 10:50 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=119eba0a-2c81-4232-8b20-acc0a0eea969@kernel.org \
--to=krzk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=conor+dt@kernel.org \
--cc=dakr@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamel.bouhara@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.