From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8D3AC6FD1F for ; Thu, 21 Mar 2024 16:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S49dHfkZRhvGjdSr++8beY2YowBVxXV9+RrlXYaulEw=; b=xvtADj3f1AKexY29SXYf2/4p1n c2ogKR8JWJ5EOItbflCaTyzPVmFosxQdC6YeUHKCeQuwgyCOAw2yd4SjxMurR++Fqpi5aFWLf+BY7 nvQDkTVrmBYRJcrBbdsMKi6Ia60fmzuDBKMvQAtjXpw3Bhp20US5tGBbfWieFix0zGv6RlGK9fGtc SejNcnns2fg2cBpj78fRZVOWQhaei7hklf5Uh2xIEya5l/PYsIPnyJA3V+RE6NVrEHKLgwQ+sujtA lzdJ1FCpyq2+c51ZH0BHeDFrh3cI3mUcUMGXBX535lX8v2QhNF7RrUgZCaYwAOyOODixKbrNtEJn6 t4Pm8f4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnLKQ-00000003nTE-0MPY; Thu, 21 Mar 2024 16:31:42 +0000 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnLKK-00000003nPM-47yi; Thu, 21 Mar 2024 16:31:39 +0000 Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-430c41f3f89so11350961cf.0; Thu, 21 Mar 2024 09:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711038695; x=1711643495; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S49dHfkZRhvGjdSr++8beY2YowBVxXV9+RrlXYaulEw=; b=e2wUfaJs0z8H66FZ0PrRNZLq6snTy5IbBGSjjmmheNM8ROTDwRo+7aQwdwkF4Lgl4E nKJXoWGEmW3M9niZumfGp+DtLhYagrvTjx3Zb2n/ISdLq920UyOelBHC0dGeYT5FzeH6 a7y6wUnnknni9wKgEuPBzUa50m4oeBH+3iNzE51xmtYGJ+jM4DuNk0OGyK4CjXs+6U12 tNtfsdbAnwfzf/ZYDisrkfwvbi9nf65gIdkdDIZ6LSdQYsC7WdInn7lIH+kDm+j4dhuR +kXPbzKreGqucqdhyIpeDT0Okvan1FLqv8rE4XYGpi5EB1EDVg2NVJ1gCflYviQ6nXVw 2Khw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711038695; x=1711643495; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S49dHfkZRhvGjdSr++8beY2YowBVxXV9+RrlXYaulEw=; b=V1Ztg4YLvqZfgIgVllfkv1UwZa0jxHmEwcKClC+lBxdO//kbPAneu3al0cIPS9HA24 P9fxaVcPxE4hqAbkogtEeDmafpY+FxdKp0iUqUnf6zeqqskhSxw/ooPIsz4turSgo+YK uzRNkFjdWm3TdLC1g+OITf/dDJOftTPHS2Kz9mQwHM03q+i3VS1ttEXjOhY4YePpjQRL LmAITAGHLb6DHXF0B2xHJ0OqclN223QvDz+1pJKF0gO+gAchlZEXSMC0Hu5F5u1xKkCP urMqFnkVcnnKqeoTCSyztUTdtFLEEAhbIWLQwQhd0JBREiHzzUV5LfIKEFrEO74xrMkp COtg== X-Forwarded-Encrypted: i=1; AJvYcCWsNa2dWcyYzWxLWOY00pNjhpou8M6GljqGhCFqWH2M8UTi8oRi5EwrEibBK2731JHxErdCiZwOrC4xyzFoJO9SnOopuPivkMRCz33DBtikYQq0mC5YqBy2v4uz8SrLVP3w4iNvPMffLsj8CD4UKhVABVWQcIH47BA= X-Gm-Message-State: AOJu0YwhdXjSv6neI0G1ci4wEpWG0A5oG9qHzs2DWultH/587Qzfk9ZE AM+2IxUlM4WQfD1r7A5TkAxLAhM94U7Lii/dS63DkEVXkLYtG+UX X-Google-Smtp-Source: AGHT+IF4Jq5m/V0phrC5UTN1Th0lDfZYqyJ+t4y8mBiUV/M6F4ub6yCG+Ho67J65LuMJkLnvA9JI2g== X-Received: by 2002:ac8:7d92:0:b0:430:d489:38e2 with SMTP id c18-20020ac87d92000000b00430d48938e2mr75298qtd.0.1711038695185; Thu, 21 Mar 2024 09:31:35 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id fk25-20020a05622a559900b00430b5dcac34sm30489qtb.8.2024.03.21.09.31.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Mar 2024 09:31:34 -0700 (PDT) Message-ID: <11b2a4d1-66d8-4bcf-b1a8-20a635b99cc4@gmail.com> Date: Thu, 21 Mar 2024 09:31:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Andrew Lunn Cc: DENG Qingfang , Sean Wang , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Ren=C3=A9_van_Dorst?= , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v> <00ec9779-19ce-4005-83f0-f4abf37350fc@arinc9.com> <6cb585f6-6da8-45a2-a28b-2fb556f95672@lunn.ch> <38798882-c033-4949-9446-4c6f15c25ebe@gmail.com> <0fbe7ba2-6529-4118-b050-8ea76d28b712@arinc9.com> From: Florian Fainelli In-Reply-To: <0fbe7ba2-6529-4118-b050-8ea76d28b712@arinc9.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240321_093137_106369_7CAB8260 X-CRM114-Status: GOOD ( 34.84 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 3/21/24 09:09, Arınç ÜNAL wrote: > On 20.03.2024 00:31, Florian Fainelli wrote: >> On 3/19/24 13:26, Daniel Golle wrote: >>> On Tue, Mar 19, 2024 at 08:38:03PM +0100, Andrew Lunn wrote: >>>>> I would argue that EEE advertisement on the PHY should be enabled by >>>>> default. >>>> >>>> That is an open question at the moment. For some use cases, it can add >>>> extra delay and jitter which can cause problems. I've heard people >>>> doing PTP don't like EEE for example. >>> >>> MediaTek consumer-grade hardware doesn't support PTP and hence that >>> quite certainly won't ever be an issue with all switch ICs supported >>> by the mt7530 driver. >>> >>> I'd rather first change the (configuration) default in OpenWrt (which >>> is arguable the way most people are using this hardware), also because >>> that will be more visible/obvious for users. Or even just make EEE >>> configurable in the LuCI web-UI as a first step so users start playing >>> with it. >>> >>> After all, I also have a hard time imagining that MediaTek disabled >>> EEE in their downstream driver for no reason: >>> >>> https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/24091177a18ba7f2dd8d928a8f5b27b14df46b16 >> >> EEE tends to be an interoperability trap and typically results in >> unexplained link drops with different link partners which are >> difficult to debug and root cause. It would be great to have more >> context as to why it was disabled in the downstream tree to know what >> we are up against, though I would not be surprised if there had been a >> number of issues reported. > > I have started testing MT7531 with EEE enabled and immediately experienced > frames that wouldn't egress the switch or improperly received on the link > partner. > > SoC MAC       <-EEE off-> MT7531 P6 MAC (acting as PHY) > MT7531 P0 MAC <-EEE on -> MT7531 P0 PHY > MT7531 P0 PHY <-EEE on -> Computer connected with twisted pair OK, so this is intended to describe that the SoC's Ethernet MAC link to the integrated switch did not use EEE only the user-facing ports. That makes sense because it's all digital logic and you are not going to be seeing much power saving from having EEE enabled between the SoC's Ethernet MAC and CPU port of the switch, that said, however, I wonder if this has an impact on any form of flow control within the switch that is reacting to LPI and you need EEE to be enabled end-to-end? > > I've tested pinging from the SoC's CPU. Packet capturing on the twisted > pair computer showed very few frames were being received. > > # ping 192.168.2.2 > PING 192.168.2.2 (192.168.2.2): 56 data bytes > 64 bytes from 192.168.2.2: seq=36 ttl=64 time=0.486 ms > ^C > --- 192.168.2.2 ping statistics --- > 64 packets transmitted, 1 packets received, 98% packet loss > round-trip min/avg/max = 0.486/0.486/0.486 ms > > It seems there's less loss when frames are passed more frequently. That would point to an issue getting in and out of LPI, do you see these packet losses even with different LPI timeouts? > > # ping 192.168.2.2 -i 0.06 > PING 192.168.2.2 (192.168.2.2): 56 data bytes > 64 bytes from 192.168.2.2: seq=5 ttl=64 time=0.285 ms > 64 bytes from 192.168.2.2: seq=6 ttl=64 time=0.155 ms > 64 bytes from 192.168.2.2: seq=7 ttl=64 time=0.243 ms > 64 bytes from 192.168.2.2: seq=8 ttl=64 time=0.139 ms > 64 bytes from 192.168.2.2: seq=9 ttl=64 time=0.224 ms > 64 bytes from 192.168.2.2: seq=68 ttl=64 time=0.350 ms > 64 bytes from 192.168.2.2: seq=69 ttl=64 time=0.242 ms > 64 bytes from 192.168.2.2: seq=70 ttl=64 time=0.230 ms > 64 bytes from 192.168.2.2: seq=71 ttl=64 time=0.242 ms > 64 bytes from 192.168.2.2: seq=72 ttl=64 time=0.276 ms > 64 bytes from 192.168.2.2: seq=101 ttl=64 time=0.224 ms > 64 bytes from 192.168.2.2: seq=102 ttl=64 time=0.238 ms > 64 bytes from 192.168.2.2: seq=103 ttl=64 time=0.240 ms > ... > --- 192.168.2.2 ping statistics --- > 214 packets transmitted, 32 packets received, 85% packet loss > round-trip min/avg/max = 0.099/0.225/0.350 ms > > # ping 192.168.2.2 -i 0.05 > PING 192.168.2.2 (192.168.2.2): 56 data bytes > 64 bytes from 192.168.2.2: seq=1 ttl=64 time=0.277 ms > 64 bytes from 192.168.2.2: seq=2 ttl=64 time=0.240 ms > 64 bytes from 192.168.2.2: seq=3 ttl=64 time=0.133 ms > 64 bytes from 192.168.2.2: seq=4 ttl=64 time=0.233 ms > 64 bytes from 192.168.2.2: seq=5 ttl=64 time=0.223 ms > 64 bytes from 192.168.2.2: seq=6 ttl=64 time=0.228 ms > 64 bytes from 192.168.2.2: seq=7 ttl=64 time=0.236 ms > 64 bytes from 192.168.2.2: seq=8 ttl=64 time=0.150 ms > ... > --- 192.168.2.2 ping statistics --- > 41 packets transmitted, 40 packets received, 2% packet loss > round-trip min/avg/max = 0.112/0.206/0.277 ms > >> >> That said as an user, if someone has a well controlled environment, >> they should absolutely be able to turn on EEE and see how stable it >> holds in their environment. > > Looks like this is the way to go. I'm planning to submit v2 with patch 1 > as: > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 678b51f9cea6..6aa99b590329 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2458,6 +2458,20 @@ mt7531_setup(struct dsa_switch *ds) >      /* Reset the switch through internal reset */ >      mt7530_write(priv, MT7530_SYS_CTRL, SYS_CTRL_SW_RST | > SYS_CTRL_REG_RST); > > +    /* Allow modifying the trap and enable Energy-Efficient Ethernet > (EEE). > +     */ > +    val = mt7530_read(priv, MT7531_HWTRAP); > +    val |= CHG_STRAP; > +    val &= ~EEE_DIS; > +    mt7530_write(priv, MT7530_MHWTRAP, val); > + > +    /* Disable EEE advertisement on the switch PHYs. */ > +    for (i = MT753X_CTRL_PHY_ADDR; > +         i < MT753X_CTRL_PHY_ADDR + MT7530_NUM_PHYS; i++) { > +        mt7531_ind_c45_phy_write(priv, i, MDIO_MMD_AN, MDIO_AN_EEE_ADV, > +                     0); > +    } > + >      if (!priv->p5_sgmii) { >          mt7531_pll_setup(priv); >      } else { > diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h > index a71166e0a7fc..509ed5362236 100644 > --- a/drivers/net/dsa/mt7530.h > +++ b/drivers/net/dsa/mt7530.h > @@ -457,6 +457,7 @@ enum mt7531_clk_skew { >  #define  XTAL_FSEL_M            BIT(7) >  #define  PHY_EN                BIT(6) >  #define  CHG_STRAP            BIT(8) > +#define  EEE_DIS            BIT(4) > >  /* Register for hw trap modification */ >  #define MT7530_MHWTRAP            0x7804 > > Arınç -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E1F4C54E58 for ; Thu, 21 Mar 2024 16:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1MZjxNHjBOc3tjTSEdc7Gi7F43FVy9iWFajdh0TlX9A=; b=Yqj9qMbbMJpndX mfix4/XjtmlhuJUkwmoz9ca9YpadqrTLSAIEsuLqSVpFeF1VFon1eyCbMmqOPVGUEpQtht4LMXJy6 qc0RmWkn7RcCRDfdVjsZ2C+I2yHlA7gBm22uWyN1A1UhC7QtNocHHvYx3rxKsj5MKdfEWM+7hgYxy 3k6zyph0g6Qgkz1E3NjwMM/LAeLGUr2VJqDR3hxuTbPG/wWszd9zRWCb25nV1HrOF5uk+/4VrfahA A12dq3SsiSchA7/UZUwU4WfqFm9/f0lShH1Gc/7rpFMLgmFWcU+OPmwzjWabGBJbkhg0ALCPYEr+U GVDm9NNmOphCBmYlereQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnLKO-00000003nSQ-3MhO; Thu, 21 Mar 2024 16:31:40 +0000 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnLKK-00000003nPM-47yi; Thu, 21 Mar 2024 16:31:39 +0000 Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-430c41f3f89so11350961cf.0; Thu, 21 Mar 2024 09:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711038695; x=1711643495; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S49dHfkZRhvGjdSr++8beY2YowBVxXV9+RrlXYaulEw=; b=e2wUfaJs0z8H66FZ0PrRNZLq6snTy5IbBGSjjmmheNM8ROTDwRo+7aQwdwkF4Lgl4E nKJXoWGEmW3M9niZumfGp+DtLhYagrvTjx3Zb2n/ISdLq920UyOelBHC0dGeYT5FzeH6 a7y6wUnnknni9wKgEuPBzUa50m4oeBH+3iNzE51xmtYGJ+jM4DuNk0OGyK4CjXs+6U12 tNtfsdbAnwfzf/ZYDisrkfwvbi9nf65gIdkdDIZ6LSdQYsC7WdInn7lIH+kDm+j4dhuR +kXPbzKreGqucqdhyIpeDT0Okvan1FLqv8rE4XYGpi5EB1EDVg2NVJ1gCflYviQ6nXVw 2Khw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711038695; x=1711643495; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S49dHfkZRhvGjdSr++8beY2YowBVxXV9+RrlXYaulEw=; b=V1Ztg4YLvqZfgIgVllfkv1UwZa0jxHmEwcKClC+lBxdO//kbPAneu3al0cIPS9HA24 P9fxaVcPxE4hqAbkogtEeDmafpY+FxdKp0iUqUnf6zeqqskhSxw/ooPIsz4turSgo+YK uzRNkFjdWm3TdLC1g+OITf/dDJOftTPHS2Kz9mQwHM03q+i3VS1ttEXjOhY4YePpjQRL LmAITAGHLb6DHXF0B2xHJ0OqclN223QvDz+1pJKF0gO+gAchlZEXSMC0Hu5F5u1xKkCP urMqFnkVcnnKqeoTCSyztUTdtFLEEAhbIWLQwQhd0JBREiHzzUV5LfIKEFrEO74xrMkp COtg== X-Forwarded-Encrypted: i=1; AJvYcCWsNa2dWcyYzWxLWOY00pNjhpou8M6GljqGhCFqWH2M8UTi8oRi5EwrEibBK2731JHxErdCiZwOrC4xyzFoJO9SnOopuPivkMRCz33DBtikYQq0mC5YqBy2v4uz8SrLVP3w4iNvPMffLsj8CD4UKhVABVWQcIH47BA= X-Gm-Message-State: AOJu0YwhdXjSv6neI0G1ci4wEpWG0A5oG9qHzs2DWultH/587Qzfk9ZE AM+2IxUlM4WQfD1r7A5TkAxLAhM94U7Lii/dS63DkEVXkLYtG+UX X-Google-Smtp-Source: AGHT+IF4Jq5m/V0phrC5UTN1Th0lDfZYqyJ+t4y8mBiUV/M6F4ub6yCG+Ho67J65LuMJkLnvA9JI2g== X-Received: by 2002:ac8:7d92:0:b0:430:d489:38e2 with SMTP id c18-20020ac87d92000000b00430d48938e2mr75298qtd.0.1711038695185; Thu, 21 Mar 2024 09:31:35 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id fk25-20020a05622a559900b00430b5dcac34sm30489qtb.8.2024.03.21.09.31.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Mar 2024 09:31:34 -0700 (PDT) Message-ID: <11b2a4d1-66d8-4bcf-b1a8-20a635b99cc4@gmail.com> Date: Thu, 21 Mar 2024 09:31:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Andrew Lunn Cc: DENG Qingfang , Sean Wang , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Ren=C3=A9_van_Dorst?= , Russell King , SkyLake Huang , Heiner Kallweit , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v> <00ec9779-19ce-4005-83f0-f4abf37350fc@arinc9.com> <6cb585f6-6da8-45a2-a28b-2fb556f95672@lunn.ch> <38798882-c033-4949-9446-4c6f15c25ebe@gmail.com> <0fbe7ba2-6529-4118-b050-8ea76d28b712@arinc9.com> From: Florian Fainelli In-Reply-To: <0fbe7ba2-6529-4118-b050-8ea76d28b712@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240321_093137_106369_7CAB8260 X-CRM114-Status: GOOD ( 34.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8yMS8yNCAwOTowOSwgQXLEsW7DpyDDnE5BTCB3cm90ZToKPiBPbiAyMC4wMy4yMDI0IDAw OjMxLCBGbG9yaWFuIEZhaW5lbGxpIHdyb3RlOgo+PiBPbiAzLzE5LzI0IDEzOjI2LCBEYW5pZWwg R29sbGUgd3JvdGU6Cj4+PiBPbiBUdWUsIE1hciAxOSwgMjAyNCBhdCAwODozODowM1BNICswMTAw LCBBbmRyZXcgTHVubiB3cm90ZToKPj4+Pj4gSSB3b3VsZCBhcmd1ZSB0aGF0IEVFRSBhZHZlcnRp c2VtZW50IG9uIHRoZSBQSFkgc2hvdWxkIGJlIGVuYWJsZWQgYnkKPj4+Pj4gZGVmYXVsdC4KPj4+ Pgo+Pj4+IFRoYXQgaXMgYW4gb3BlbiBxdWVzdGlvbiBhdCB0aGUgbW9tZW50LiBGb3Igc29tZSB1 c2UgY2FzZXMsIGl0IGNhbiBhZGQKPj4+PiBleHRyYSBkZWxheSBhbmQgaml0dGVyIHdoaWNoIGNh biBjYXVzZSBwcm9ibGVtcy4gSSd2ZSBoZWFyZCBwZW9wbGUKPj4+PiBkb2luZyBQVFAgZG9uJ3Qg bGlrZSBFRUUgZm9yIGV4YW1wbGUuCj4+Pgo+Pj4gTWVkaWFUZWsgY29uc3VtZXItZ3JhZGUgaGFy ZHdhcmUgZG9lc24ndCBzdXBwb3J0IFBUUCBhbmQgaGVuY2UgdGhhdAo+Pj4gcXVpdGUgY2VydGFp bmx5IHdvbid0IGV2ZXIgYmUgYW4gaXNzdWUgd2l0aCBhbGwgc3dpdGNoIElDcyBzdXBwb3J0ZWQK Pj4+IGJ5IHRoZSBtdDc1MzAgZHJpdmVyLgo+Pj4KPj4+IEknZCByYXRoZXIgZmlyc3QgY2hhbmdl IHRoZSAoY29uZmlndXJhdGlvbikgZGVmYXVsdCBpbiBPcGVuV3J0ICh3aGljaAo+Pj4gaXMgYXJn dWFibGUgdGhlIHdheSBtb3N0IHBlb3BsZSBhcmUgdXNpbmcgdGhpcyBoYXJkd2FyZSksIGFsc28g YmVjYXVzZQo+Pj4gdGhhdCB3aWxsIGJlIG1vcmUgdmlzaWJsZS9vYnZpb3VzIGZvciB1c2Vycy4g T3IgZXZlbiBqdXN0IG1ha2UgRUVFCj4+PiBjb25maWd1cmFibGUgaW4gdGhlIEx1Q0kgd2ViLVVJ IGFzIGEgZmlyc3Qgc3RlcCBzbyB1c2VycyBzdGFydCBwbGF5aW5nCj4+PiB3aXRoIGl0Lgo+Pj4K Pj4+IEFmdGVyIGFsbCwgSSBhbHNvIGhhdmUgYSBoYXJkIHRpbWUgaW1hZ2luaW5nIHRoYXQgTWVk aWFUZWsgZGlzYWJsZWQKPj4+IEVFRSBpbiB0aGVpciBkb3duc3RyZWFtIGRyaXZlciBmb3Igbm8g cmVhc29uOgo+Pj4KPj4+IGh0dHBzOi8vZ2l0MDEubWVkaWF0ZWsuY29tL3BsdWdpbnMvZ2l0aWxl cy9vcGVud3J0L2ZlZWRzL210ay1vcGVud3J0LWZlZWRzLysvMjQwOTExNzdhMThiYTdmMmRkOGQ5 MjhhOGY1YjI3YjE0ZGY0NmIxNgo+Pgo+PiBFRUUgdGVuZHMgdG8gYmUgYW4gaW50ZXJvcGVyYWJp bGl0eSB0cmFwIGFuZCB0eXBpY2FsbHkgcmVzdWx0cyBpbiAKPj4gdW5leHBsYWluZWQgbGluayBk cm9wcyB3aXRoIGRpZmZlcmVudCBsaW5rIHBhcnRuZXJzIHdoaWNoIGFyZSAKPj4gZGlmZmljdWx0 IHRvIGRlYnVnIGFuZCByb290IGNhdXNlLiBJdCB3b3VsZCBiZSBncmVhdCB0byBoYXZlIG1vcmUg Cj4+IGNvbnRleHQgYXMgdG8gd2h5IGl0IHdhcyBkaXNhYmxlZCBpbiB0aGUgZG93bnN0cmVhbSB0 cmVlIHRvIGtub3cgd2hhdCAKPj4gd2UgYXJlIHVwIGFnYWluc3QsIHRob3VnaCBJIHdvdWxkIG5v dCBiZSBzdXJwcmlzZWQgaWYgdGhlcmUgaGFkIGJlZW4gYSAKPj4gbnVtYmVyIG9mIGlzc3VlcyBy ZXBvcnRlZC4KPiAKPiBJIGhhdmUgc3RhcnRlZCB0ZXN0aW5nIE1UNzUzMSB3aXRoIEVFRSBlbmFi bGVkIGFuZCBpbW1lZGlhdGVseSBleHBlcmllbmNlZAo+IGZyYW1lcyB0aGF0IHdvdWxkbid0IGVn cmVzcyB0aGUgc3dpdGNoIG9yIGltcHJvcGVybHkgcmVjZWl2ZWQgb24gdGhlIGxpbmsKPiBwYXJ0 bmVyLgo+IAo+IFNvQyBNQUPCoMKgwqDCoMKgwqAgPC1FRUUgb2ZmLT4gTVQ3NTMxIFA2IE1BQyAo YWN0aW5nIGFzIFBIWSkKPiBNVDc1MzEgUDAgTUFDIDwtRUVFIG9uIC0+IE1UNzUzMSBQMCBQSFkK PiBNVDc1MzEgUDAgUEhZIDwtRUVFIG9uIC0+IENvbXB1dGVyIGNvbm5lY3RlZCB3aXRoIHR3aXN0 ZWQgcGFpcgoKT0ssIHNvIHRoaXMgaXMgaW50ZW5kZWQgdG8gZGVzY3JpYmUgdGhhdCB0aGUgU29D J3MgRXRoZXJuZXQgTUFDIGxpbmsgdG8gCnRoZSBpbnRlZ3JhdGVkIHN3aXRjaCBkaWQgbm90IHVz ZSBFRUUgb25seSB0aGUgdXNlci1mYWNpbmcgcG9ydHMuIFRoYXQgCm1ha2VzIHNlbnNlIGJlY2F1 c2UgaXQncyBhbGwgZGlnaXRhbCBsb2dpYyBhbmQgeW91IGFyZSBub3QgZ29pbmcgdG8gYmUgCnNl ZWluZyBtdWNoIHBvd2VyIHNhdmluZyBmcm9tIGhhdmluZyBFRUUgZW5hYmxlZCBiZXR3ZWVuIHRo ZSBTb0MncyAKRXRoZXJuZXQgTUFDIGFuZCBDUFUgcG9ydCBvZiB0aGUgc3dpdGNoLCB0aGF0IHNh aWQsIGhvd2V2ZXIsIEkgd29uZGVyIGlmIAp0aGlzIGhhcyBhbiBpbXBhY3Qgb24gYW55IGZvcm0g b2YgZmxvdyBjb250cm9sIHdpdGhpbiB0aGUgc3dpdGNoIHRoYXQgaXMgCnJlYWN0aW5nIHRvIExQ SSBhbmQgeW91IG5lZWQgRUVFIHRvIGJlIGVuYWJsZWQgZW5kLXRvLWVuZD8KCj4gCj4gSSd2ZSB0 ZXN0ZWQgcGluZ2luZyBmcm9tIHRoZSBTb0MncyBDUFUuIFBhY2tldCBjYXB0dXJpbmcgb24gdGhl IHR3aXN0ZWQKPiBwYWlyIGNvbXB1dGVyIHNob3dlZCB2ZXJ5IGZldyBmcmFtZXMgd2VyZSBiZWlu ZyByZWNlaXZlZC4KPiAKPiAjIHBpbmcgMTkyLjE2OC4yLjIKPiBQSU5HIDE5Mi4xNjguMi4yICgx OTIuMTY4LjIuMik6IDU2IGRhdGEgYnl0ZXMKPiA2NCBieXRlcyBmcm9tIDE5Mi4xNjguMi4yOiBz ZXE9MzYgdHRsPTY0IHRpbWU9MC40ODYgbXMKPiBeQwo+IC0tLSAxOTIuMTY4LjIuMiBwaW5nIHN0 YXRpc3RpY3MgLS0tCj4gNjQgcGFja2V0cyB0cmFuc21pdHRlZCwgMSBwYWNrZXRzIHJlY2VpdmVk LCA5OCUgcGFja2V0IGxvc3MKPiByb3VuZC10cmlwIG1pbi9hdmcvbWF4ID0gMC40ODYvMC40ODYv MC40ODYgbXMKPiAKPiBJdCBzZWVtcyB0aGVyZSdzIGxlc3MgbG9zcyB3aGVuIGZyYW1lcyBhcmUg cGFzc2VkIG1vcmUgZnJlcXVlbnRseS4KClRoYXQgd291bGQgcG9pbnQgdG8gYW4gaXNzdWUgZ2V0 dGluZyBpbiBhbmQgb3V0IG9mIExQSSwgZG8geW91IHNlZSB0aGVzZSAKcGFja2V0IGxvc3NlcyBl dmVuIHdpdGggZGlmZmVyZW50IExQSSB0aW1lb3V0cz8KCj4gCj4gIyBwaW5nIDE5Mi4xNjguMi4y IC1pIDAuMDYKPiBQSU5HIDE5Mi4xNjguMi4yICgxOTIuMTY4LjIuMik6IDU2IGRhdGEgYnl0ZXMK PiA2NCBieXRlcyBmcm9tIDE5Mi4xNjguMi4yOiBzZXE9NSB0dGw9NjQgdGltZT0wLjI4NSBtcwo+ IDY0IGJ5dGVzIGZyb20gMTkyLjE2OC4yLjI6IHNlcT02IHR0bD02NCB0aW1lPTAuMTU1IG1zCj4g NjQgYnl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTcgdHRsPTY0IHRpbWU9MC4yNDMgbXMKPiA2 NCBieXRlcyBmcm9tIDE5Mi4xNjguMi4yOiBzZXE9OCB0dGw9NjQgdGltZT0wLjEzOSBtcwo+IDY0 IGJ5dGVzIGZyb20gMTkyLjE2OC4yLjI6IHNlcT05IHR0bD02NCB0aW1lPTAuMjI0IG1zCj4gNjQg Ynl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTY4IHR0bD02NCB0aW1lPTAuMzUwIG1zCj4gNjQg Ynl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTY5IHR0bD02NCB0aW1lPTAuMjQyIG1zCj4gNjQg Ynl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTcwIHR0bD02NCB0aW1lPTAuMjMwIG1zCj4gNjQg Ynl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTcxIHR0bD02NCB0aW1lPTAuMjQyIG1zCj4gNjQg Ynl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTcyIHR0bD02NCB0aW1lPTAuMjc2IG1zCj4gNjQg Ynl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTEwMSB0dGw9NjQgdGltZT0wLjIyNCBtcwo+IDY0 IGJ5dGVzIGZyb20gMTkyLjE2OC4yLjI6IHNlcT0xMDIgdHRsPTY0IHRpbWU9MC4yMzggbXMKPiA2 NCBieXRlcyBmcm9tIDE5Mi4xNjguMi4yOiBzZXE9MTAzIHR0bD02NCB0aW1lPTAuMjQwIG1zCj4g Li4uCj4gLS0tIDE5Mi4xNjguMi4yIHBpbmcgc3RhdGlzdGljcyAtLS0KPiAyMTQgcGFja2V0cyB0 cmFuc21pdHRlZCwgMzIgcGFja2V0cyByZWNlaXZlZCwgODUlIHBhY2tldCBsb3NzCj4gcm91bmQt dHJpcCBtaW4vYXZnL21heCA9IDAuMDk5LzAuMjI1LzAuMzUwIG1zCj4gCj4gIyBwaW5nIDE5Mi4x NjguMi4yIC1pIDAuMDUKPiBQSU5HIDE5Mi4xNjguMi4yICgxOTIuMTY4LjIuMik6IDU2IGRhdGEg Ynl0ZXMKPiA2NCBieXRlcyBmcm9tIDE5Mi4xNjguMi4yOiBzZXE9MSB0dGw9NjQgdGltZT0wLjI3 NyBtcwo+IDY0IGJ5dGVzIGZyb20gMTkyLjE2OC4yLjI6IHNlcT0yIHR0bD02NCB0aW1lPTAuMjQw IG1zCj4gNjQgYnl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTMgdHRsPTY0IHRpbWU9MC4xMzMg bXMKPiA2NCBieXRlcyBmcm9tIDE5Mi4xNjguMi4yOiBzZXE9NCB0dGw9NjQgdGltZT0wLjIzMyBt cwo+IDY0IGJ5dGVzIGZyb20gMTkyLjE2OC4yLjI6IHNlcT01IHR0bD02NCB0aW1lPTAuMjIzIG1z Cj4gNjQgYnl0ZXMgZnJvbSAxOTIuMTY4LjIuMjogc2VxPTYgdHRsPTY0IHRpbWU9MC4yMjggbXMK PiA2NCBieXRlcyBmcm9tIDE5Mi4xNjguMi4yOiBzZXE9NyB0dGw9NjQgdGltZT0wLjIzNiBtcwo+ IDY0IGJ5dGVzIGZyb20gMTkyLjE2OC4yLjI6IHNlcT04IHR0bD02NCB0aW1lPTAuMTUwIG1zCj4g Li4uCj4gLS0tIDE5Mi4xNjguMi4yIHBpbmcgc3RhdGlzdGljcyAtLS0KPiA0MSBwYWNrZXRzIHRy YW5zbWl0dGVkLCA0MCBwYWNrZXRzIHJlY2VpdmVkLCAyJSBwYWNrZXQgbG9zcwo+IHJvdW5kLXRy aXAgbWluL2F2Zy9tYXggPSAwLjExMi8wLjIwNi8wLjI3NyBtcwo+IAo+Pgo+PiBUaGF0IHNhaWQg YXMgYW4gdXNlciwgaWYgc29tZW9uZSBoYXMgYSB3ZWxsIGNvbnRyb2xsZWQgZW52aXJvbm1lbnQs IAo+PiB0aGV5IHNob3VsZCBhYnNvbHV0ZWx5IGJlIGFibGUgdG8gdHVybiBvbiBFRUUgYW5kIHNl ZSBob3cgc3RhYmxlIGl0IAo+PiBob2xkcyBpbiB0aGVpciBlbnZpcm9ubWVudC4KPiAKPiBMb29r cyBsaWtlIHRoaXMgaXMgdGhlIHdheSB0byBnby4gSSdtIHBsYW5uaW5nIHRvIHN1Ym1pdCB2MiB3 aXRoIHBhdGNoIDEKPiBhczoKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZHNhL210NzUz MC5jIGIvZHJpdmVycy9uZXQvZHNhL210NzUzMC5jCj4gaW5kZXggNjc4YjUxZjljZWE2Li42YWE5 OWI1OTAzMjkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvZHNhL210NzUzMC5jCj4gKysrIGIv ZHJpdmVycy9uZXQvZHNhL210NzUzMC5jCj4gQEAgLTI0NTgsNiArMjQ1OCwyMCBAQCBtdDc1MzFf c2V0dXAoc3RydWN0IGRzYV9zd2l0Y2ggKmRzKQo+ICDCoMKgwqDCoCAvKiBSZXNldCB0aGUgc3dp dGNoIHRocm91Z2ggaW50ZXJuYWwgcmVzZXQgKi8KPiAgwqDCoMKgwqAgbXQ3NTMwX3dyaXRlKHBy aXYsIE1UNzUzMF9TWVNfQ1RSTCwgU1lTX0NUUkxfU1dfUlNUIHwgCj4gU1lTX0NUUkxfUkVHX1JT VCk7Cj4gCj4gK8KgwqDCoCAvKiBBbGxvdyBtb2RpZnlpbmcgdGhlIHRyYXAgYW5kIGVuYWJsZSBF bmVyZ3ktRWZmaWNpZW50IEV0aGVybmV0IAo+IChFRUUpLgo+ICvCoMKgwqDCoCAqLwo+ICvCoMKg wqAgdmFsID0gbXQ3NTMwX3JlYWQocHJpdiwgTVQ3NTMxX0hXVFJBUCk7Cj4gK8KgwqDCoCB2YWwg fD0gQ0hHX1NUUkFQOwo+ICvCoMKgwqAgdmFsICY9IH5FRUVfRElTOwo+ICvCoMKgwqAgbXQ3NTMw X3dyaXRlKHByaXYsIE1UNzUzMF9NSFdUUkFQLCB2YWwpOwo+ICsKPiArwqDCoMKgIC8qIERpc2Fi bGUgRUVFIGFkdmVydGlzZW1lbnQgb24gdGhlIHN3aXRjaCBQSFlzLiAqLwo+ICvCoMKgwqAgZm9y IChpID0gTVQ3NTNYX0NUUkxfUEhZX0FERFI7Cj4gK8KgwqDCoMKgwqDCoMKgwqAgaSA8IE1UNzUz WF9DVFJMX1BIWV9BRERSICsgTVQ3NTMwX05VTV9QSFlTOyBpKyspIHsKPiArwqDCoMKgwqDCoMKg wqAgbXQ3NTMxX2luZF9jNDVfcGh5X3dyaXRlKHByaXYsIGksIE1ESU9fTU1EX0FOLCBNRElPX0FO X0VFRV9BRFYsCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMCk7 Cj4gK8KgwqDCoCB9Cj4gKwo+ICDCoMKgwqDCoCBpZiAoIXByaXYtPnA1X3NnbWlpKSB7Cj4gIMKg wqDCoMKgwqDCoMKgwqAgbXQ3NTMxX3BsbF9zZXR1cChwcml2KTsKPiAgwqDCoMKgwqAgfSBlbHNl IHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZHNhL210NzUzMC5oIGIvZHJpdmVycy9uZXQv ZHNhL210NzUzMC5oCj4gaW5kZXggYTcxMTY2ZTBhN2ZjLi41MDllZDUzNjIyMzYgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9uZXQvZHNhL210NzUzMC5oCj4gKysrIGIvZHJpdmVycy9uZXQvZHNhL210 NzUzMC5oCj4gQEAgLTQ1Nyw2ICs0NTcsNyBAQCBlbnVtIG10NzUzMV9jbGtfc2tldyB7Cj4gIMKg I2RlZmluZcKgIFhUQUxfRlNFTF9NwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCSVQoNykKPiAgwqAj ZGVmaW5lwqAgUEhZX0VOwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEJJVCg2KQo+ICDC oCNkZWZpbmXCoCBDSEdfU1RSQVDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEJJVCg4KQo+ICsjZGVm aW5lwqAgRUVFX0RJU8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgQklUKDQpCj4gCj4gIMKgLyogUmVn aXN0ZXIgZm9yIGh3IHRyYXAgbW9kaWZpY2F0aW9uICovCj4gIMKgI2RlZmluZSBNVDc1MzBfTUhX VFJBUMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMHg3ODA0Cj4gCj4gQXLEsW7DpwoKLS0gCkZsb3Jp YW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==