From: Tyler Baicar <tbaicar@codeaurora.org>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-edac@vger.kernel.org, astone@redhat.com, fu.wei@linaro.org,
shiju.jose@huawei.com
Subject: [V2,1/2] rasdaemon: add support for non standard CPER section events
Date: Thu, 8 Jun 2017 11:28:56 -0600 [thread overview]
Message-ID: <11b7e505-8682-5c53-e2fb-c5b1eb3e8a8c@codeaurora.org> (raw)
On 6/8/2017 3:16 AM, Mauro Carvalho Chehab wrote:
> Em Fri, 2 Jun 2017 15:40:32 -0600
> Tyler Baicar <tbaicar@codeaurora.org> escreveu:
>
>> Add support to handle the non standard CPER section kernel trace
>> events which cover RAS errors who's section type is unknown.
>>
>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
>> Cc: Shiju Jose <shiju.jose@huawei.com>
> There is something wrong with this patch... it doesn't build ;)
>
> ras-report.c: In function ‘set_non_standard_event_backtrace’:
> ras-report.c:218:18: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘const char *’ [-Wformat=]
> sprintf(bt_buf, "BACKTRACE=" \
> ^~~~~~~~~~~~
> CCLD rasdaemon
> ras-non-standard-handler.o: In function `ras_non_standard_event_handler':
> /devel/edac/rasdaemon/ras-non-standard-handler.c:143: undefined reference to `ras_report_non_standard_record'
>
> ras-report.c: In function ‘set_non_standard_event_backtrace’:
> ras-report.c:224:9: error: ‘struct ras_non_standard_event’ has no member named ‘error_count’
> ev->error_count, \
> ^~
Oops, you're right! I didn't notice that because I haven't been using
the --enable-abrt-report configure option :)
I'll fix this in both of these patches and send a new patch series out.
Thanks,
Tyler
next reply other threads:[~2017-06-08 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 17:28 Tyler Baicar [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-08 9:16 [V2,1/2] rasdaemon: add support for non standard CPER section events Mauro Carvalho Chehab
2017-06-02 21:40 Tyler Baicar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11b7e505-8682-5c53-e2fb-c5b1eb3e8a8c@codeaurora.org \
--to=tbaicar@codeaurora.org \
--cc=astone@redhat.com \
--cc=fu.wei@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.