[Buildroot] [PATCH 1/1] mke2img: Sanity check block size and fail if zero or missing.

[g4 at novadsp.com <g4@novadsp.com>]

Hello Yann,

> 
> >      # Sanity checks
> >      if [ -z "${root_dir}" ]; then
> > -        error "you must specify a root directory with '-d'\n"
> > +        error "Error: you must specify a root directory with '-d'\n"
> >      fi
> >      if [ -z "${image}" ]; then
> > -        error "you must specify an output image file with '-o'\n"
> > +        error "Error: you must specify an output image file with '-o'\n"
> 
> Is that really necessary?

The original justification was for any user calling the script directly. Now I think no, it is not.
 
> 
> There is an obvious error here: there is a missing space between '0' and the
> closing bracket ']'.

Indeed. <facepalm>
 
> However, I wonder why we should check for a zero size. The filesystem will
> be non-creatable (is that a word?) because the requested size is too low,
> similar to what a user would get by settign the nb_blocks to
> (e.g.) 1024 (i.e. 1MiB) but have a target/ that is 2MiB: that won't fit.
> 
> So, I would just keep the check to being set, whatever the value (but I would
> not oppose the check against 0 either.)

My revised version applies a check in the ext2.mk file itself. I think this is much cleaner.

Best,

Jerry.