All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: buildroot@buildroot.org, Bernd Kuhls <bernd@kuhls.net>,
	Michael Walle <michael@walle.cc>, Bryan Brattlof <bb@ti.com>
Subject: Re: [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue
Date: Sat, 12 Jul 2025 13:53:26 +0200	[thread overview]
Message-ID: <11f9e821cdf9106557a006c973654036@free.fr> (raw)
In-Reply-To: <20250711120544.315926-2-heiko.thiery@gmail.com>

Hi Heiko,

Thanks for the patch.

On 11/07/2025 14:05, Heiko Thiery wrote:
> This "powervr" directory has been present in linux-firmware since
> version 20231211.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/linux-firmware/Config.in         | 5 +++++
>  package/linux-firmware/linux-firmware.mk | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/package/linux-firmware/Config.in 
> b/package/linux-firmware/Config.in
> index 34f3fb7691..54910df6fd 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -729,6 +729,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_ARM_MALI_CSF
>  	  Firmware files for Arm Mali 10th generation GPU
>  	  needed by the linux panthor kernel driver.
> 
> +config BR2_PACKAGE_LINUX_FIRMWARE_POWERVR_ROGUE
> +	bool "PowerVR Technologies Rogue GPU firmware"
> +	help
> +	  Firmware files for PowerVR Technologies Rogue video cards.
> +
>  endmenu
> 
>  menu "Serial adapters firmware"
> diff --git a/package/linux-firmware/linux-firmware.mk 
> b/package/linux-firmware/linux-firmware.mk
> index 38212e12ac..b9fd471e85 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -931,6 +931,11 @@ LINUX_FIRMWARE_FILES += 
> arm/mali/arch*/mali_csffw.bin
>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.mali_csffw
>  endif
> 
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_POWERVR_ROGUE),y)
> +LINUX_FIRMWARE_DIRS += powervr
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.powervr

Running "make linux-firmware-legal-info" with this firmware selected
generates a warning/error:

     ERROR: No hash found for LICENSE.powervr

Could you add the hash for this new file, please? In:
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/linux-firmware/linux-firmware.hash


> +endif
> +
>  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RP2),y)
>  LINUX_FIRMWARE_FILES += rp2.fw
>  endif
> --
> 2.39.5

Could you send an updated patch series, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-07-12 11:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 12:05 [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Heiko Thiery
2025-07-11 12:05 ` [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue Heiko Thiery
2025-07-12 11:53   ` Julien Olivain via buildroot [this message]
2025-07-12 11:50 ` [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Julien Olivain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11f9e821cdf9106557a006c973654036@free.fr \
    --to=buildroot@buildroot.org \
    --cc=bb@ti.com \
    --cc=bernd@kuhls.net \
    --cc=heiko.thiery@gmail.com \
    --cc=ju.o@free.fr \
    --cc=michael@walle.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.