From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 1/2] x86/spec: fix reporting of BHB clearing usage from guest entry points
Date: Thu, 18 Apr 2024 17:59:12 +0200 [thread overview]
Message-ID: <11fecd33-68ba-41f7-a17d-71f64554590e@suse.com> (raw)
In-Reply-To: <20240418155208.7771-2-roger.pau@citrix.com>
On 18.04.2024 17:52, Roger Pau Monne wrote:
> Reporting whether the BHB clearing on entry is done for the different domains
> types based on cpu_has_bhb_seq is incorrect, as that variable signals whether
> there's a BHB clearing sequence selected, but that alone doesn't imply that
> such sequence is used from the PV and/or HVM entry points.
>
> Instead use opt_bhb_entry_{pv,hvm} which do signal whether BHB clearing is
> performed on entry from PV/HVM.
>
> Fixes: 689ad48ce9cf ('x86/spec-ctrl: Wire up the Native-BHI software sequences')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
This looks correct to me, so:
Reviewed-by: Jan Beulich <jbeulich@suse.com>
But since Andrew indicated concerns, I won't mark it (locally) for being
ready to go in.
Jan
next prev parent reply other threads:[~2024-04-18 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 15:52 [PATCH v2 0/2] x86/spec: misc fixes for XSA-456 Roger Pau Monne
2024-04-18 15:52 ` [PATCH v2 1/2] x86/spec: fix reporting of BHB clearing usage from guest entry points Roger Pau Monne
2024-04-18 15:59 ` Jan Beulich [this message]
2024-04-25 13:08 ` Andrew Cooper
2024-04-18 15:52 ` [PATCH v2 2/2] x86/spec: adjust logic to logic that elides lfence Roger Pau Monne
2024-04-19 6:25 ` Jan Beulich
2024-04-22 13:35 ` Roger Pau Monné
2024-04-22 13:59 ` Jan Beulich
2024-04-25 13:30 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11fecd33-68ba-41f7-a17d-71f64554590e@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.