From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95631C02180 for ; Thu, 16 Jan 2025 08:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ozlabs.org; s=201707; t=1737016323; bh=rN0J1+seu0kQL0TljnKp9L4eqo2t0IggsjyZGXWUoVU=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TpRcY+FSbTbYJvKuJLJnK8+3r0DaQgQ72aaR2bOq2u0JF5kkJISENGCOg/FP9LYI8 8a0HjXyO1+6eqYgULl6PD8Yu07snWgIUftlDnUDrQp91lf+Lh/vUwHVwm6qHyBS3yq pEK8UQymZ/UfGYcNoFhcA//20VC0WtxwDuJNu14cS5c4euDxi6t/hpZCXhbBFXQEER V2BY2NQkYS2KXJGyOnazoWRhTDikBsnGfz+/qXDLJr9phezAV/bS+LENvSsrtKP4ca ZLiT7Ch3iTET+8H7U/Cfs3GNAOEmARhptubNC8BJVbh9hvjbYkU6GsAKnkYPbGNUp0 7MRTuPHwVVrUg== Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YYbh36PfTz3cds for ; Thu, 16 Jan 2025 19:32:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:45d1:ec00::3" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737016321; cv=none; b=T4cVEZ+cv8gJNi+Y3yZ3vMv0EVnkT/QZ8sRUuxdqF/uD8Hc7lEU49rQJ1hi/DFO4yNkNRLowz4b26xFYymk2cYxt3afwQWDLk9QX24WL15V7Pe/skMWAcRJ4aJWNPbYRBKyJus6oKueLUr9mTns7C/+vhAORTyy+qLtb5nGnzTIu7Zz+Wti2oqW1BWneyzF78EyCYDzttmJpDbeCFRU+TGWnrd2Z3IGicMo+bd0Vl5t8qNBnjIIg0AbNpoc6IMcLS/axn54kkkQ+VgkIWI73ixBWfA94HMIcrJGN8iTKbqfwsGONFOSpjUMyJiFAWqC9R+9GmBPBQ97V53TarEr4yw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737016321; c=relaxed/relaxed; bh=rN0J1+seu0kQL0TljnKp9L4eqo2t0IggsjyZGXWUoVU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=WzkH3gb5Y6AqwjXRQ4JLfGuqVvCtcpd+ELpqKQvGMiXv0fnELN1+E1LBWxUU1TvTCEQUU4ZdGaQXnNfS68iitoq85I3nixUq+/TnY4gKwTzkCR0GHH4NKQaj2t8biuW8vTIC7wOW/PhBTajS1wQcYjvWzZz0yOjxQtY4hRvbapVUOXe3sK/MZGG3YP55Pa5ej51iaKIREbryUuItAqE46wQoRQsD+rDSJJo+7bd1jiXbUSbqn9qhbesmSm1Q8jgjWgWYvHavj+wfTHZcFE98k96nI8ByOzuB3ZELPhHEYbBhT4H5P4yZV7rZ2+TRc75c2MxKEmeGeifCiL+gRPca4Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Q98Qk1Sa; dkim-atps=neutral; spf=pass (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=chao@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Q98Qk1Sa; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=chao@kernel.org; receiver=lists.ozlabs.org) Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YYbh12hVvz2ysc for ; Thu, 16 Jan 2025 19:32:01 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 48A45A4116E; Thu, 16 Jan 2025 08:30:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22A5FC4CED6; Thu, 16 Jan 2025 08:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737016318; bh=nM3Q7CZXxvDLM64A/7/nEQ//gngY5Eok3yDCRO4vquQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Q98Qk1SaKAQ+0j09MuNoD375OlLzgR4MHhRxHC/4pqc31xV1KDn7ySLBXNSxkCvdV 2nSSizY1xDC2qFUgPn9qQUgJ1jPTCmSnOwo76U+ULs6iMvgOXVc+XyapuiHNHn76ru 2DVsgntk/L2Evs04b18UU7Jr6HIfuvYuuGidc0Xx+wLTSDGH18pPhIjPhrKHgvq7Ro /jk07ITsY+2SzIKduYSZtrsztUJxyq7ejIkFDzKQ5cLir4OpJrQIaJV7rJmal6yZ/3 Tu5ckx3iXFXKaMnNgiqqwOMkk458+pMvNgcKbzUcvDfmR3ZDNKVQjUnngLy11Niaeo cHy+f8Ub50/JA== Message-ID: <11ffcd03-c3ce-4d2b-8360-1968092f72c1@kernel.org> Date: Thu, 16 Jan 2025 16:31:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan() To: Gao Xiang , linux-erofs@lists.ozlabs.org References: <20250114040058.459981-1-hsiangkao@linux.alibaba.com> Content-Language: en-US In-Reply-To: <20250114040058.459981-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-erofs Reply-To: Chao Yu Cc: LKML Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 1/14/25 12:00, Gao Xiang wrote: > z_erofs_shrink_scan() could return small numbers due to the mistyped > `freed`. > > Although I don't think it has any visible impact. Agreed, it's an extreme case... > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F61157E88 for ; Thu, 16 Jan 2025 08:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737016319; cv=none; b=HqMKyeBOH94QKwAhnnmJT6uEL6zpj2RkTGNglNqOiCwfyys4CZBETtgz+BE4wsX6ypWNDkb3d5bEYEzG5KLHVwOVyiYOyQ8uzPjGHzHiUoTm2BuAbxi8+bwZ6OSXhfKYS1S65DbxjuFoBIo6IS6GzCp5YtRhHZ8ElVrkUWJAzNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737016319; c=relaxed/simple; bh=nM3Q7CZXxvDLM64A/7/nEQ//gngY5Eok3yDCRO4vquQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=uM764s7nF232q5EMXa5hWYNS1MdnrgPke92mwb4S1wPT9ZtEeGGnT+As90jC9bk8fZO2+kGVrMsasfQDgdRH9mURjMm8S7f2ao14zmqJWuqwAoYsMQLeRzUPLu2JVFh0Dy4xXhX3aTdLhS4wwDRFfK0q7ud3mzycaYIGyNHsN2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q98Qk1Sa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q98Qk1Sa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22A5FC4CED6; Thu, 16 Jan 2025 08:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737016318; bh=nM3Q7CZXxvDLM64A/7/nEQ//gngY5Eok3yDCRO4vquQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Q98Qk1SaKAQ+0j09MuNoD375OlLzgR4MHhRxHC/4pqc31xV1KDn7ySLBXNSxkCvdV 2nSSizY1xDC2qFUgPn9qQUgJ1jPTCmSnOwo76U+ULs6iMvgOXVc+XyapuiHNHn76ru 2DVsgntk/L2Evs04b18UU7Jr6HIfuvYuuGidc0Xx+wLTSDGH18pPhIjPhrKHgvq7Ro /jk07ITsY+2SzIKduYSZtrsztUJxyq7ejIkFDzKQ5cLir4OpJrQIaJV7rJmal6yZ/3 Tu5ckx3iXFXKaMnNgiqqwOMkk458+pMvNgcKbzUcvDfmR3ZDNKVQjUnngLy11Niaeo cHy+f8Ub50/JA== Message-ID: <11ffcd03-c3ce-4d2b-8360-1968092f72c1@kernel.org> Date: Thu, 16 Jan 2025 16:31:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, LKML Subject: Re: [PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan() To: Gao Xiang , linux-erofs@lists.ozlabs.org References: <20250114040058.459981-1-hsiangkao@linux.alibaba.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20250114040058.459981-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/25 12:00, Gao Xiang wrote: > z_erofs_shrink_scan() could return small numbers due to the mistyped > `freed`. > > Although I don't think it has any visible impact. Agreed, it's an extreme case... > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,