From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JEQBB-0000KX-IR for mharc-grub-devel@gnu.org; Mon, 14 Jan 2008 09:20:45 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JEQB9-0000Jt-Ce for grub-devel@gnu.org; Mon, 14 Jan 2008 09:20:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JEQB7-0000JY-Ga for grub-devel@gnu.org; Mon, 14 Jan 2008 09:20:42 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JEQB7-0000JT-AY for grub-devel@gnu.org; Mon, 14 Jan 2008 09:20:41 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JEQB7-0004N1-5N for grub-devel@gnu.org; Mon, 14 Jan 2008 09:20:41 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 14 Jan 2008 09:20:40 -0500 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 509B7618FE1 for ; Mon, 14 Jan 2008 09:20:40 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080113203041.GA25702@thorin> References: <20080113203041.GA25702@thorin> Content-Type: text/plain Date: Mon, 14 Jan 2008 09:20:39 -0500 Message-Id: <1200320439.13534.4.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 (2.12.2-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix endianess in IEEE-1275 integer properties X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 14:20:44 -0000 On Sun, 2008-01-13 at 21:30 +0100, Robert Millan wrote: > Integer properties are always in big endian. This (incomplete) patch is my > suggested approach to deal with this. I'd like to receive input about it > before I complete it (checking all calls to grub_ieee1275_get_property > through GRUB and replacing with grub_ieee1275_get_integer_property when > appropiate). > > Again, some testing on Apple/IBM/Genesi hardware would be nice. It doesn't apply cleanly, and I don't see how the result of grub_ieee1275_get_integer_property() is used. I suggest that you go ahead with the changes as long as you get them right for your platform. -- Regards, Pavel Roskin