From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: rdunlap@xenotime.net, apw@shadowen.org, jschopp@austin.ibm.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Checkpatch.pl failure
Date: Mon, 14 Jan 2008 09:48:53 -0600 [thread overview]
Message-ID: <1200325734.3159.1.camel@localhost.localdomain> (raw)
This error:
ERROR: no space before that close parenthesis ')'
#501: FILE: drivers/scsi/dpt_i2o.c:2299:
+ if (dev_status == 0x02 /*CHECK_CONDITION*/) {
Is definitely wrong. I think it's stripped the comments so now the if
looks to have a space before the bracket, but stylistically the
complaint it has errored out for is wrong.
James
next reply other threads:[~2008-01-14 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 15:48 James Bottomley [this message]
2008-01-14 16:18 ` Checkpatch.pl failure Benny Halevy
2008-01-14 17:10 ` Andy Whitcroft
2008-01-14 19:04 ` Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200325734.3159.1.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.