From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JEpoE-00080m-JB
	for mharc-grub-devel@gnu.org; Tue, 15 Jan 2008 12:42:46 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JEpoC-0007zH-Ig
	for grub-devel@gnu.org; Tue, 15 Jan 2008 12:42:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JEpoA-0007yK-1A
	for grub-devel@gnu.org; Tue, 15 Jan 2008 12:42:44 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JEpo9-0007yC-PH
	for grub-devel@gnu.org; Tue, 15 Jan 2008 12:42:41 -0500
Received: from c60.cesmail.net ([216.154.195.49])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <proski@gnu.org>) id 1JEpo9-0003FT-B2
	for grub-devel@gnu.org; Tue, 15 Jan 2008 12:42:41 -0500
Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81])
	by c60.cesmail.net with ESMTP; 15 Jan 2008 12:42:40 -0500
Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net
	[72.92.88.10])
	by relay.cesmail.net (Postfix) with ESMTP id F23E2618FE1
	for <grub-devel@gnu.org>; Tue, 15 Jan 2008 12:42:39 -0500 (EST)
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <20080115171747.GA14625@thorin>
References: <20080115171747.GA14625@thorin>
Content-Type: text/plain
Date: Tue, 15 Jan 2008 12:42:39 -0500
Message-Id: <1200418959.17542.6.camel@dv>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.2 (2.12.2-3.fc8) 
Content-Transfer-Encoding: 7bit
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] improve grub_mm_init_region() debug message
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jan 2008 17:42:45 -0000


On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote:
> -  grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n",
> addr, (unsigned int) size);
> +  grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n",
> addr, addr + size);

Maybe addr+size-1 would be better?  Inclusive boundaries are more
intuitive.  Just run "cat /proc/iomem" to see what I mean.

-- 
Regards,
Pavel Roskin