From: Mingming Cao <cmm@us.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: checkpatch.pl warnings
Date: Tue, 15 Jan 2008 11:34:59 -0800 [thread overview]
Message-ID: <1200425699.4072.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20080115125224.GA18227@skywalker>
On Tue, 2008-01-15 at 18:22 +0530, Aneesh Kumar K.V wrote:
> On Mon, Jan 14, 2008 at 12:49:27PM -0800, Mingming Cao wrote:
> > Hi Guys,
> >
> > Could you check the checkpatch.pl warnings and see if it make sense to fix them? Thanks!
> >
> > cmm@kernel:~/fs/ext4/stylecheck$ grep "has style problems" *
> > linux-2.6.24-rc7-48-bit-i_blocks.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-ext3-4-migrate.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-ext4_export_iov_shorten_from_kernel_for_ext4.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-ext4-journal_chksum-2.6.20.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-ext4_rec_len_overflow_with_64kblk_fix-v2.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-ext4_store_maxbytes_for_bitmaped_files.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-inode-version-ext4.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-jbd-stats-through-procfs.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-large-file-blocktype.patch.out:Your patch has style problems, please review. If any of these errors
> > linux-2.6.24-rc7-mballoc-core.patch.out:Your patch has style problems, please review. If any of these errors
> >
>
> Fixed the checkpatch.pl warning for all the patches in the patch queue.
> The diff is attached below for review.
Thanks!
patch queue has been updated.
Mingming
next prev parent reply other threads:[~2008-01-15 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 20:42 [Fwd: [Bug 9732] New: oops in extent code via ext4_fallocate] Eric Sandeen
2008-01-12 16:31 ` Aneesh Kumar K.V
2008-01-12 16:41 ` Eric Sandeen
2008-01-12 16:44 ` Eric Sandeen
[not found] ` <1200343767.4197.7.camel@localhost.localdomain>
2008-01-15 12:52 ` checkpatch.pl warnings Aneesh Kumar K.V
2008-01-15 19:34 ` Mingming Cao [this message]
2008-01-12 18:14 ` [PATCH] ext4: use ext4_ext_get_actual_len instead of directly using ext4_extent.ee_len Aneesh Kumar K.V
2008-01-14 10:35 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200425699.4072.0.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.