From: Joonwoo Park <joonwpark81@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Joonwoo Park <joonwpark81@gmail.com>,
linux-netdev <netdev@vger.kernel.org>,
Stephen Hemminger <stephen.hemminger@vyatta.com>,
Alexander Zubkov <green@msu.ru>
Subject: [PATCH 1/2] [IPV4] fib_hash: fix duplicated route issue
Date: Wed, 16 Jan 2008 20:13:25 +0900 [thread overview]
Message-ID: <12004820052610-git-send-email-joonwpark81@gmail.com> (raw)
http://bugzilla.kernel.org/show_bug.cgi?id=9493
The fib allows making identical routes with 'ip route replace'.
This patch makes the fib return -EEXIST if replacement would cause duplication.
Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
---
net/ipv4/fib_hash.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c
index 527a6e0..99071d7 100644
--- a/net/ipv4/fib_hash.c
+++ b/net/ipv4/fib_hash.c
@@ -444,6 +444,9 @@ static int fn_hash_insert(struct fib_table *tb, struct fib_config *cfg)
struct fib_info *fi_drop;
u8 state;
+ if (fi->fib_treeref > 1)
+ goto out;
+
write_lock_bh(&fib_hash_lock);
fi_drop = fa->fa_info;
fa->fa_info = fi;
--
1.5.3.rc5
next reply other threads:[~2008-01-16 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 11:13 Joonwoo Park [this message]
2008-01-18 11:44 ` [PATCH 1/2] [IPV4] fib_hash: fix duplicated route issue David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12004820052610-git-send-email-joonwpark81@gmail.com \
--to=joonwpark81@gmail.com \
--cc=davem@davemloft.net \
--cc=green@msu.ru \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.