From: Harvey Harrison <harvey.harrison@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Roland McGrath <roland@redhat.com>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Use v8086_mode helper, trivial unification
Date: Thu, 17 Jan 2008 18:02:07 -0800 [thread overview]
Message-ID: <1200621727.5724.96.camel@brick> (raw)
In-Reply-To: <479002B6.9030607@zytor.com>
On Thu, 2008-01-17 at 20:36 -0500, H. Peter Anvin wrote:
> Roland McGrath wrote:
> > It's indeed true that &pt_regs is truly the esp value for x86-32
> > kernel-mode trap frames. Because this nonobvious calculation is
> > only right for a kernel mode pt_regs and not for a user-mode one,
> > I think it would be better to use a name for the inline/macro that
> > makes this quite clear, rather than one so generic as "stack_addr".
>
> Indeed. This was certainly highly nonobvious in the current code.
>
What do you think of kernel_sp()
Harvey
next prev parent reply other threads:[~2008-01-18 2:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 23:04 [PATCH] x86: Use v8086_mode helper, trivial unification Harvey Harrison
2008-01-17 23:02 ` H. Peter Anvin
2008-01-17 23:26 ` Harvey Harrison
2008-01-18 0:59 ` H. Peter Anvin
2008-01-18 1:14 ` Harvey Harrison
2008-01-18 1:14 ` H. Peter Anvin
2008-01-18 1:23 ` Harvey Harrison
2008-01-18 1:15 ` Harvey Harrison
2008-01-18 1:37 ` Roland McGrath
2008-01-18 1:36 ` H. Peter Anvin
2008-01-18 2:02 ` Harvey Harrison [this message]
2008-01-18 2:21 ` Harvey Harrison
2008-01-18 3:35 ` H. Peter Anvin
2008-01-18 4:28 ` [PATCH] x86: Rename stack_pointer to kernel_trap_sp Harvey Harrison
2008-01-18 9:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200621727.5724.96.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.