From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JGPtE-0004Kx-2S for mharc-grub-devel@gnu.org; Sat, 19 Jan 2008 21:26:28 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGPtC-0004Ki-67 for grub-devel@gnu.org; Sat, 19 Jan 2008 21:26:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGPt7-0004KU-Qt for grub-devel@gnu.org; Sat, 19 Jan 2008 21:26:24 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGPt7-0004KQ-Gk for grub-devel@gnu.org; Sat, 19 Jan 2008 21:26:21 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JGPt7-0005yj-7D for grub-devel@gnu.org; Sat, 19 Jan 2008 21:26:21 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 19 Jan 2008 21:26:16 -0500 Received: from [192.168.1.28] (pool-96-227-20-21.phlapa.east.verizon.net [96.227.20.21]) by relay.cesmail.net (Postfix) with ESMTP id ED2DA618FE1 for ; Sat, 19 Jan 2008 21:26:15 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080119215043.GA2909@thorin> References: <20080115171747.GA14625@thorin> <1200418959.17542.6.camel@dv> <20080115180055.GA21551@thorin> <20080119215043.GA2909@thorin> Content-Type: text/plain Date: Sat, 19 Jan 2008 21:26:15 -0500 Message-Id: <1200795975.7266.0.camel@rd> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 (2.12.2-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] improve grub_mm_init_region() debug message X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jan 2008 02:26:26 -0000 On Sat, 2008-01-19 at 22:50 +0100, Robert Millan wrote: > On Tue, Jan 15, 2008 at 07:00:55PM +0100, Robert Millan wrote: > > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: > > > > > > On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: > > > > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", > > > > addr, (unsigned int) size); > > > > + grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n", > > > > addr, addr + size); > > > > > > Maybe addr+size-1 would be better? Inclusive boundaries are more > > > intuitive. Just run "cat /proc/iomem" to see what I mean. > > > > Sounds better to me. > > > > Does this change (with addr + size -1) sound fine to everyone else? > > Uhm actually, since we already substract one on ieee1275 to workaround > firmware bugs, this might get confusing. Oh, I didn't know that. > How about just "addr + size" ? Fine with me. -- Regards, Pavel Roskin