Re: PATCH: scsi-sd-last-sector-bug-flag.patch

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Sun, 2008-01-20 at 11:12 +0100, Hans de Goede wrote:
> Hi all,
> 
> This patch adds a new scsi_device flag for devices which contain a bug where
> the device crashes when the last sector is read in a larger then 1 sector read.
> 
> This is for example the case with sdcards in the HP PSC1350 printer cardreader
> and in the HP PSC1610 printer cardreader.
> 
> Signed-off-by: Hans de Goede <j.w.r.degoede@hhs.nl>

This could have done with running through checkpatch.pl:

ERROR: trailing whitespace
#28: FILE: drivers/scsi/sd.c:398:
+^I/* $

ERROR: trailing whitespace
#32: FILE: drivers/scsi/sd.c:402:
+^Iif (unlikely(sdp->last_sector_bug && $

WARNING: braces {} are not necessary for single statement blocks
#32: FILE: drivers/scsi/sd.c:402:
+       if (unlikely(sdp->last_sector_bug && 
+           rq->nr_sectors > sdp->sector_size / 512 &&
+           block + this_count == get_capacity(disk))) {
+               this_count -= sdp->sector_size / 512;
+       }

ERROR: use tabs not spaces
#34: FILE: drivers/scsi/sd.c:404:
+ ^I    block + this_count == get_capacity(disk))) {$

WARNING: line over 80 characters
#49: FILE: include/scsi/scsi_device.h:142:
+       unsigned last_sector_bug:1;     /* Always read last sector in a
1 sector read */

total: 3 errors, 2 warnings, 23 lines checked

I've fixed all of these up.

James