From: Harvey Harrison <harvey.harrison@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] [RFC] x86: Make page fault oopses similar
Date: Mon, 21 Jan 2008 13:35:06 -0800 [thread overview]
Message-ID: <1200951306.16972.28.camel@brick> (raw)
In-Reply-To: <20080121132920.6975077d@laptopd505.fenrus.org>
On Mon, 2008-01-21 at 13:29 -0800, Arjan van de Ven wrote:
> On Mon, 21 Jan 2008 13:20:46 -0800
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > Introduce printk_address to X86_32 in a simplified form for
> > now. Reformat X86_64 printk_address to avoid two declarations.
> >
> > Change the printk formats on X86_32 and 64 to be similar.
>
> I'm not entirely convinced on this; I need to look closer but it appears the 32 bit version
> doesn't use the "reliable" argument to print a ? in front of the dubious backtrace entries;
> that would be sort of a step backwards; (
>
Sorry, I should have made it clearer that this was more for discussion
of the actual formatting.
printk_address needs to be ported to X86_32, the one in this patch
is just a placeholder. Looking at the X86_64 version it looks like
it can be brought straight across, but I haven't tested that yet.
Harvey
prev parent reply other threads:[~2008-01-21 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 21:20 [PATCH 2/2] [RFC] x86: Make page fault oopses similar Harvey Harrison
2008-01-21 21:29 ` Arjan van de Ven
2008-01-21 21:35 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200951306.16972.28.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.