From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JH8bV-0005Xt-ME for mharc-grub-devel@gnu.org; Mon, 21 Jan 2008 21:11:09 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JH8bT-0005Xm-Vn for grub-devel@gnu.org; Mon, 21 Jan 2008 21:11:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JH8bS-0005XZ-H3 for grub-devel@gnu.org; Mon, 21 Jan 2008 21:11:07 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH8bS-0005XW-Bi for grub-devel@gnu.org; Mon, 21 Jan 2008 21:11:06 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JH8bS-0007GL-3B for grub-devel@gnu.org; Mon, 21 Jan 2008 21:11:06 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 21 Jan 2008 21:11:05 -0500 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 44644618FE1 for ; Mon, 21 Jan 2008 21:11:05 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080121210641.GC15119@thorin> References: <20080121165209.GA2557@thorin> <1200937626.4686.17.camel@dv> <20080121210641.GC15119@thorin> Content-Type: text/plain Date: Mon, 21 Jan 2008 21:11:04 -0500 Message-Id: <1200967864.32578.52.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 (2.12.2-3.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] memdisk + grub-mkrescue X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2008 02:11:08 -0000 On Mon, 2008-01-21 at 22:06 +0100, Robert Millan wrote: > On Mon, Jan 21, 2008 at 12:47:06PM -0500, Pavel Roskin wrote: > > On Mon, 2008-01-21 at 17:52 +0100, Robert Millan wrote: > > > These two were predestined to get together.. attached patch for their > > > wedding. > > > > > > Comments? > > > > I really like the ability to add more things than just modules > > (especially grub.cfg and fonts). Is that the main motivation for your > > patch? Or you have some other things in mind? > > Yes, that's it. Specially for situations in which there's no other way > (like netboot images, or in the future coreboot when it works on ELF). I wish I could use it on PowerPC to work around the "claim failed" problem, but I'll still need to link "memdisk" and "cpio" with grub-mkimage. I have a patch for PowerPC, but I think I'll hold it until your patch is committed. I could change my patch to be more in-sync with i386, in particular use /boot/grub as the blessed directory. > > I don't quite understand why "biosdisk" needs to be mandatory. I guess > > it's not initialized by default, so that it doesn't conflict with the > > ata module. But ata can load on top of biosdisk (but not the other way > > around). > > I just added it because we don't seem to have a way to define which modules > should be autoloaded (other than grub.cfg itself). And I'm afraid not loading > it by default will confuse users. I don't know how to improve this, but ideas > are welcome, of course. Actually, if biosdisk is a part of the core image, other modules are preloaded. I don't quite understand the mechanism. I think it should be OK for now. Then we can refine the loading and the initialization. -- Regards, Pavel Roskin