From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JI6uC-0000xp-Aq
	for mharc-grub-devel@gnu.org; Thu, 24 Jan 2008 13:34:28 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JI6uA-0000xL-Ez
	for grub-devel@gnu.org; Thu, 24 Jan 2008 13:34:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JI6u8-0000x1-HP
	for grub-devel@gnu.org; Thu, 24 Jan 2008 13:34:25 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JI6u8-0000wy-Cp
	for grub-devel@gnu.org; Thu, 24 Jan 2008 13:34:24 -0500
Received: from c60.cesmail.net ([216.154.195.49])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16)
	(Exim 4.60) (envelope-from <proski@gnu.org>) id 1JI6u8-0005ax-1w
	for grub-devel@gnu.org; Thu, 24 Jan 2008 13:34:24 -0500
Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81])
	by c60.cesmail.net with ESMTP; 24 Jan 2008 13:34:22 -0500
Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net
	[72.92.88.10])
	by relay.cesmail.net (Postfix) with ESMTP id B40CB618FE1
	for <grub-devel@gnu.org>; Thu, 24 Jan 2008 13:34:22 -0500 (EST)
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <4798D42E.7030506@nic.fi>
References: <94a0ccbc0801231500g752f72acodc37c733726d8919@mail.gmail.com>
	<20080124000544.GB32503@thorin>  <4798D42E.7030506@nic.fi>
Content-Type: text/plain; charset=ISO-8859-1
Date: Thu, 24 Jan 2008 13:34:22 -0500
Message-Id: <1201199662.19286.4.camel@dv>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) 
Content-Transfer-Encoding: 8bit
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: /kern/file.c BUG
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jan 2008 18:34:26 -0000

On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote:

> Previous behavior was working correctly. You have to handle
> errorcodes 
> at some point and that means when error is handled it is zeroed (or 
> GRUB_ERR_NONE). So code is in callee where that loop was.

I suggest that we never set grub_errno to 0 (except the initialization).
That would match the standard errno behavior:

http://www.opengroup.org/onlinepubs/009695399/functions/errno.html

-- 
Regards,
Pavel Roskin