From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Pekka Paalanen <pq@iki.fi>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] x86: Add a list for custom page fault handlers.
Date: Sun, 27 Jan 2008 22:03:31 +0100 [thread overview]
Message-ID: <1201467811.6149.0.camel@lappy> (raw)
In-Reply-To: <20080127185238.4bcac54b@daedalus.pq.iki.fi>
On Sun, 2008-01-27 at 18:52 +0200, Pekka Paalanen wrote:
> +void unregister_page_fault_handler(struct pf_handler *old_pfh)
> +{
> + might_sleep();
> + spin_lock(&pf_handlers_writer);
> + hlist_del_rcu(&old_pfh->hlist);
> + spin_unlock(&pf_handlers_writer);
> + synchronize_rcu();
> +}
> +EXPORT_SYMBOL_GPL(unregister_page_fault_handler);
Could you remove that sync_rcu() call and put in the comments that the
calling function is to take care of proper freeing.
sync_rcu() is a _very_ expensive call, and oft time it is not needed in
favour of call_rcu().
next prev parent reply other threads:[~2008-01-27 21:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 16:52 [PATCH] x86: Add a list for custom page fault handlers Pekka Paalanen
2008-01-27 17:55 ` [RFC PATCH] x86: mmiotrace - trace memory mapped IO Pekka Paalanen
2008-01-30 22:39 ` Pekka Paalanen
2008-01-27 19:29 ` [PATCH] x86: Add a list for custom page fault handlers Ingo Molnar
2008-01-27 21:03 ` Peter Zijlstra [this message]
2008-01-30 2:28 ` Harvey Harrison
2008-01-30 2:34 ` Harvey Harrison
2008-01-30 18:08 ` Pekka Paalanen
2008-01-31 15:07 ` Ingo Molnar
2008-01-31 16:02 ` [PATCH v2] " Pekka Paalanen
2008-01-31 16:15 ` Arjan van de Ven
2008-02-03 6:55 ` Pekka Paalanen
2008-02-03 7:03 ` Ingo Molnar
2008-02-03 21:40 ` Pekka Paalanen
2008-02-05 20:28 ` [PATCH 1/4] x86 mmiotrace: use lookup_address() Pekka Paalanen
2008-02-05 20:30 ` [PATCH 2/4] x86 mmiotrace: fix relay-buffer-full flag for SMP Pekka Paalanen
2008-02-05 20:44 ` Eric Dumazet
2008-02-05 21:14 ` Pekka Paalanen
2008-02-05 21:35 ` Eric Dumazet
2008-02-09 17:53 ` [PATCH] x86 mmiotrace: Use percpu instead of arrays Pekka Paalanen
2008-02-05 20:31 ` [PATCH 3/4] x86 mmiotrace: comment about user space ABI Pekka Paalanen
2008-02-05 20:39 ` [PATCH 4/4] x86 mmiotrace: move files into arch/x86/mm/ Pekka Paalanen
2008-02-06 3:02 ` Randy Dunlap
2008-02-09 11:21 ` Pekka Paalanen
2008-02-07 12:53 ` Ingo Molnar
2008-02-07 12:56 ` Christoph Hellwig
2008-02-09 17:52 ` [RFC PATCH] x86: explicit call to mmiotrace in do_page_fault() Pekka Paalanen
2008-02-09 18:01 ` Arjan van de Ven
2008-02-09 18:23 ` Pekka Paalanen
2008-02-09 18:56 ` Pekka Enberg
2008-02-09 19:11 ` Pekka Paalanen
2008-02-09 19:19 ` Pekka Enberg
2008-02-09 18:39 ` Peter Zijlstra
2008-02-09 18:39 ` Peter Zijlstra
2008-02-10 18:05 ` [RFC PATCH v2] " Pekka Paalanen
2008-02-11 2:12 ` Pavel Roskin
2008-02-11 18:04 ` Pekka Paalanen
2008-02-06 5:00 ` [PATCH 1/4] x86 mmiotrace: use lookup_address() Christoph Hellwig
2008-02-07 12:52 ` Ingo Molnar
2008-01-31 16:16 ` [RFC PATCH v2] x86: mmiotrace - trace memory mapped IO Pekka Paalanen
2008-01-31 16:29 ` Arjan van de Ven
2008-02-03 7:21 ` Pekka Paalanen
2008-01-30 18:20 ` [PATCH] x86: Add a list for custom page fault handlers Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201467811.6149.0.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pq@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.