From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JJKct-0004lr-FG for mharc-grub-devel@gnu.org; Sun, 27 Jan 2008 22:25:39 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJKcr-0004jf-P5 for grub-devel@gnu.org; Sun, 27 Jan 2008 22:25:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJKcp-0004hM-Qo for grub-devel@gnu.org; Sun, 27 Jan 2008 22:25:37 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJKcp-0004hH-Ne for grub-devel@gnu.org; Sun, 27 Jan 2008 22:25:35 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JJKcp-0000RZ-PM for grub-devel@gnu.org; Sun, 27 Jan 2008 22:25:35 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 27 Jan 2008 22:25:34 -0500 Received: from [192.168.1.28] (pool-96-227-20-21.phlapa.east.verizon.net [96.227.20.21]) by relay.cesmail.net (Postfix) with ESMTP id 95522618FE1; Sun, 27 Jan 2008 22:25:33 -0500 (EST) From: Pavel Roskin To: Robert Millan , The development of GRUB 2 Content-Type: text/plain Date: Sun, 27 Jan 2008 22:25:32 -0500 Message-Id: <1201490732.20392.15.camel@rd> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Subject: Redefining GRUB_MOD_GAP in init.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 03:25:38 -0000 Hi Robert, I'm concerned about your latest commit: * kern/powerpc/ieee1275/init.c (grub_arch_modules_addr): Skip `GRUB_MOD_GAP' for platforms in which it's not defined. The algorithm for calculating the start of the modules should be exactly the same in grub-mkimage and in the core. Any fallbacks should be coherent if possible. Therefore, I think it would be better to define GRUB_MOD_GAP only in header files. It's hard for me to understand why kern/powerpc/ieee1275/init.c can be used on any platform other than PowerPC. I was assuming that my changes would not affect other platforms. Also, I don't see how GRUB_MOD_GAP would not be defined to 0x8000 for i386-ieee1275 platform considering that include/grub/i386/ieee1275/kernel.h simply includes include/grub/powerpc/ieee1275/kernel.h I suggest that i386-ieee1275 stops using any files for PowerPC. kernel.h is not big, so it shouldn't be a problem to copy it. As for init.c, it should be either copied or moved to a more suitable place. -- Regards, Pavel Roskin