From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
tomof@acm.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] zfcp: fix sense_buffer access bug
Date: Mon, 28 Jan 2008 07:53:52 -0500 [thread overview]
Message-ID: <1201524832.3105.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20080128100446.GA4732@schmichrtp.de.ibm.com>
On Mon, 2008-01-28 at 11:04 +0100, Christof Schmitt wrote:
> On Mon, Jan 28, 2008 at 06:29:12PM +0900, FUJITA Tomonori wrote:
> > > ACK for fixing the access to the sense buffer.
> > >
> > > We are working internally on cleaning up the zfcp messages. With this
> > > change, the 'trace' and 'hex dump' messages will disappear. So, could
> > > you simply remove the ZFCP_HEX_DUMP message above, instead of fixing
> > > it?
> >
> > I can but James has already merged the above patch to scsi-misc. So it
> > would be more convenient for everyone if you could rebase your
> > patchset on top of scsi-misc?
>
> Ok, if the pach is already merged, i am fine with that. We will have
> to rebase the patches we are working on anyway. Thanks for providing
> the fix.
It's in my upstream tree, but not merged with Linus and I can easily
rebase. However, it is a critical bug fix, without it the driver will
likely oops from overwriting command structures, so I'd rather keep it
separate from any cleanup patches.
James
prev parent reply other threads:[~2008-01-28 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 3:41 [PATCH] zfcp: fix sense_buffer access bug FUJITA Tomonori
2008-01-28 7:46 ` Christof Schmitt
2008-01-28 9:29 ` FUJITA Tomonori
2008-01-28 10:04 ` Christof Schmitt
2008-01-28 12:53 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201524832.3105.5.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=christof.schmitt@de.ibm.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.