From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Date: Tue, 29 Jan 2008 16:41:38 +0000 Subject: Re: [kvm-ppc-devel] [PATCH 1/5] Remove KVM_HANDLER macro. Message-Id: <1201624898.22639.20.camel@basalt> List-Id: References: <12012451794158-git-send-email-wei.zhang@freescale.com> In-Reply-To: <12012451794158-git-send-email-wei.zhang@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Tue, 2008-01-29 at 14:02 +0800, Zhang Wei wrote: > > > However, now that we've gotten away from binary patching the branch > > instruction, I'm not eager to go back to that with the "li" > > instruction. > > Each handler is only 24 bytes, so I'm not that worried about > > duplicating > > them, and the readability and simplicity are better with the > > duplication. > > > > Another reason is e500 have additional exceptions for SPE exceptions > (IVOR32 - IVOR35). > And there are hole from IVOR16 to IVOR 31. If we use fixed macro > functions definition, > we will leave blank functions there. How about it? True, in that case I think your approach will be best. Could you rebase the patch? -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel