From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marcel Holtmann To: David Miller In-Reply-To: <20080129.211446.254604070.davem@davemloft.net> References: <20080130022354.GA3132@darkstar.te-china.tietoenator.com> <20080129.211446.254604070.davem@davemloft.net> Date: Wed, 30 Jan 2008 11:21:02 +0100 Message-Id: <1201688462.6218.47.camel@violet> Mime-Version: 1.0 Cc: netdev@vger.kernel.org, bluez-devel@lists.sf.net, linux-kernel@vger.kernel.org Subject: Re: [Bluez-devel] [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail Reply-To: BlueZ development List-Id: BlueZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net Hi Dave, > > The bluetooth hci_conn sysfs add/del executed in the default workqueue. > > If the del_conn is executed after the new add_conn with same target, > > add_conn will failed with warning of "same kobject name". > > > > Here add btaddconn & btdelconn workqueues, > > flush the btdelconn workqueue in the add_conn function to avoid the issue. > > > > Signed-off-by: Dave Young > > This looks good, applied, thanks Dave. > > I've queued this up for 2.6.25 merging, if you want me to > schedule it for -stable, just let me know. don't include it. I first have to stress test it on one of my machines. Besides that I have to do some coding style cleanups. Regards Marcel ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Bluez-devel mailing list Bluez-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bluez-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761586AbYA3KX2 (ORCPT ); Wed, 30 Jan 2008 05:23:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755669AbYA3KVF (ORCPT ); Wed, 30 Jan 2008 05:21:05 -0500 Received: from senator.holtmann.net ([87.106.208.187]:50450 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759696AbYA3KVB (ORCPT ); Wed, 30 Jan 2008 05:21:01 -0500 Subject: Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail From: Marcel Holtmann To: David Miller Cc: hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org, bluez-devel@lists.sourceforge.net, netdev@vger.kernel.org In-Reply-To: <20080129.211446.254604070.davem@davemloft.net> References: <20080130022354.GA3132@darkstar.te-china.tietoenator.com> <20080129.211446.254604070.davem@davemloft.net> Content-Type: text/plain Date: Wed, 30 Jan 2008 11:21:02 +0100 Message-Id: <1201688462.6218.47.camel@violet> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, > > The bluetooth hci_conn sysfs add/del executed in the default workqueue. > > If the del_conn is executed after the new add_conn with same target, > > add_conn will failed with warning of "same kobject name". > > > > Here add btaddconn & btdelconn workqueues, > > flush the btdelconn workqueue in the add_conn function to avoid the issue. > > > > Signed-off-by: Dave Young > > This looks good, applied, thanks Dave. > > I've queued this up for 2.6.25 merging, if you want me to > schedule it for -stable, just let me know. don't include it. I first have to stress test it on one of my machines. Besides that I have to do some coding style cleanups. Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail Date: Wed, 30 Jan 2008 11:21:02 +0100 Message-ID: <1201688462.6218.47.camel@violet> References: <20080130022354.GA3132@darkstar.te-china.tietoenator.com> <20080129.211446.254604070.davem@davemloft.net> Reply-To: BlueZ development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bluez-devel@lists.sf.net, linux-kernel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20080129.211446.254604070.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bluez-devel-bounces@lists.sourceforge.net Errors-To: bluez-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org Hi Dave, > > The bluetooth hci_conn sysfs add/del executed in the default workqueue. > > If the del_conn is executed after the new add_conn with same target, > > add_conn will failed with warning of "same kobject name". > > > > Here add btaddconn & btdelconn workqueues, > > flush the btdelconn workqueue in the add_conn function to avoid the issue. > > > > Signed-off-by: Dave Young > > This looks good, applied, thanks Dave. > > I've queued this up for 2.6.25 merging, if you want me to > schedule it for -stable, just let me know. don't include it. I first have to stress test it on one of my machines. Besides that I have to do some coding style cleanups. Regards Marcel ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/