From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: davem@davemloft.net, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] scsi/qlogicpti.c section fixes
Date: Wed, 30 Jan 2008 15:00:16 -0600 [thread overview]
Message-ID: <1201726817.3292.84.camel@localhost.localdomain> (raw)
In-Reply-To: <20080130200336.GN29368@does.not.exist>
On Wed, 2008-01-30 at 22:03 +0200, Adrian Bunk wrote:
> This patch fixes the following section mismatches:
>
> <-- snip -->
>
> ...
> WARNING: drivers/scsi/qlogicpti.o(.devexit.text+0x8): Section mismatch in reference from the function qpti_sbus_remove() to the function .init.text:qpti_chain_del()
> WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x56c): Section mismatch in reference from the function qpti_sbus_probe() to the function .init.text:qpti_map_regs()
> WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x580): Section mismatch in reference from the function qpti_sbus_probe() to the function .init.text:qpti_register_irq()
> WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x594): Section mismatch in reference from the function qpti_sbus_probe() to the function .init.text:qpti_get_scsi_id()
> WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x5b8): Section mismatch in reference from the function qpti_sbus_probe() to the function .init.text:qpti_map_queues()
> WARNING: drivers/scsi/qlogicpti.o(.devinit.text+0x780): Section mismatch in reference from the function qpti_sbus_probe() to the function .init.text:qpti_chain_add()
> ...
OK, look, this is really getting out of hand.
__init is possibly justifiable with a few hundred k savings on boot.
__devinit and the rest are surely killable on the grounds they provide
little benefit for all the pain they cause.
all __exit seems to do is set us up for unreferenced pointers in
discarded sections, so could we kill that too?
James
next prev parent reply other threads:[~2008-01-30 21:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 20:03 [2.6 patch] scsi/qlogicpti.c section fixes Adrian Bunk
2008-01-30 21:00 ` James Bottomley [this message]
2008-01-30 21:20 ` Sam Ravnborg
2008-01-30 21:30 ` Adrian Bunk
2008-01-30 21:41 ` James Bottomley
2008-01-30 22:00 ` Sam Ravnborg
2008-01-30 22:32 ` Value of __*{init,exit} anotations? Adrian Bunk
2008-01-30 22:44 ` James Bottomley
2008-01-30 22:50 ` Russell King
2008-01-31 5:42 ` Andi Kleen
2008-01-31 7:44 ` Sam Ravnborg
2008-01-31 15:57 ` [PATCH] kill hotplug init/exit section annotations James Bottomley
2008-01-31 16:11 ` Arjan van de Ven
2008-01-31 16:21 ` Adrian Bunk
2008-01-31 17:07 ` Arjan van de Ven
2008-01-31 17:14 ` Adrian Bunk
2008-01-31 17:45 ` Chris Wedgwood
2008-01-31 17:55 ` Adrian Bunk
2008-01-31 18:32 ` Chris Wedgwood
2008-01-31 18:52 ` Geert Uytterhoeven
2008-01-31 17:48 ` Arjan van de Ven
2008-01-31 18:34 ` Sam Ravnborg
2008-01-31 18:48 ` Arjan van de Ven
2008-01-31 19:41 ` Sam Ravnborg
2008-01-30 22:28 ` [2.6 patch] scsi/qlogicpti.c section fixes Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201726817.3292.84.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.