From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JL2Ho-0005EW-EF for mharc-grub-devel@gnu.org; Fri, 01 Feb 2008 15:14:56 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JL2Hn-0005EQ-Pi for grub-devel@gnu.org; Fri, 01 Feb 2008 15:14:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JL2Hm-0005E2-BY for grub-devel@gnu.org; Fri, 01 Feb 2008 15:14:55 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JL2Hm-0005Dz-5E for grub-devel@gnu.org; Fri, 01 Feb 2008 15:14:54 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JL2Hm-0000YA-2x for grub-devel@gnu.org; Fri, 01 Feb 2008 15:14:54 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 01 Feb 2008 15:14:52 -0500 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 855CD61905A for ; Fri, 1 Feb 2008 15:14:52 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080201184413.GA9474@io.com> References: <20080131160805.GA6114@io.com> <1201798681.14129.2.camel@dv> <20080201043402.GA5385@io.com> <1201841437.18433.70.camel@dv> <20080201125939.GA7004@io.com> <1201886730.7586.22.camel@dv> <20080201184413.GA9474@io.com> Content-Type: text/plain Date: Fri, 01 Feb 2008 15:14:51 -0500 Message-Id: <1201896891.3789.14.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Does grub2 solve this problem I am having with grub1? RE: usbsticks. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2008 20:14:55 -0000 On Fri, 2008-02-01 at 12:44 -0600, Paul Elliott wrote: > > One possible approach would be to use LVM (Logical Volume Manager) - > > it's supported by grub2. You could install grub on a small boot > > partition and allocate the rest to as an LVM partition, that would be > > split into volumes. Then you could refer to the volumes by name. > > > > This seems a long way to drag the cat around the barn. Or this > would be like kicking dead whales down the beach. One should > not have to invoke the complexity of LVN just so one can specify > partitions. OK, let's fix GRUB. As for the expansion issue, I think I see how to fix it. grub_script_arg_add() should append expanded variables to the last argument, rather than allocate a new argument, unless the new argument is separated by spaces from the previous one. GRUB_SCRIPT_ARG_TYPE_STR and GRUB_SCRIPT_ARG_TYPE_VAR are "write only". I think we should discard grub_script_arg_type_t or use it to keep track of spaces in the input. As for the "boot_device", it could be set in the same place as "root", namely in grub_set_root_dev() in kern/main.c. -- Regards, Pavel Roskin