From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: maximilian attems <max@stro.at>
Cc: James Smart <James.Smart@Emulex.Com>,
linux-scsi@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: lpfc build failure in latest git
Date: Sat, 02 Feb 2008 09:54:29 -0600 [thread overview]
Message-ID: <1201967669.3187.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20080202143613.GA4941@stro.at>
On Sat, 2008-02-02 at 15:36 +0100, maximilian attems wrote:
> CC [M] drivers/scsi/lpfc/lpfc_init.o
> drivers/scsi/lpfc/lpfc_init.c: In function ‘lpfc_pci_probe_one’:
> drivers/scsi/lpfc/lpfc_init.c:1897: error: implicit declaration of function ‘pci_enable_device_bars’
> make[6]: *** [drivers/scsi/lpfc/lpfc_init.o] Error 1
>
> seen on both x86 archs.
Oh, Greg was supposed to add this if he merged last. I'll send it
through the SCSI tree.
James
Subject: git-scsi-misc vs gregkh-pci-pci-remove-users-of-pci_enable_device_bars
From: Andrew Morton <akpm@linux-foundation.org>
Whoever merges last needs this.
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/scsi/lpfc/lpfc_init.c~git-scsi-misc-vs-gregkh-pci-pci-remove-users-of-pci_enable_device_bars drivers/scsi/lpfc/lpfc_init.c
--- a/drivers/scsi/lpfc/lpfc_init.c~git-scsi-misc-vs-gregkh-pci-pci-remove-users-of-pci_enable_device_bars
+++ a/drivers/scsi/lpfc/lpfc_init.c
@@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
uint16_t iotag;
int bars = pci_select_bars(pdev, IORESOURCE_MEM);
- if (pci_enable_device_bars(pdev, bars))
+ if (pci_enable_device_mem(pdev))
goto out;
if (pci_request_selected_regions(pdev, bars, LPFC_DRIVER_NAME))
goto out_disable_device;
_
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-02-02 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 14:36 lpfc build failure in latest git maximilian attems
2008-02-02 15:54 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201967669.3187.1.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=James.Smart@Emulex.Com \
--cc=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
--cc=max@stro.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.