From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasmus Rohde <rohde@duff.dk>
Subject: Re: [NFS] [PATCH] Make UDF exportable
Date: Tue, 05 Feb 2008 20:26:01 +0100
Message-ID: <1202239561.12188.53.camel@localhost.localdomain>
References: <1201726404.2976.8.camel@localhost.localdomain>
	 <20080205102955.GA28347@infradead.org>
	 <1202233464.12188.43.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: nfs@lists.sourceforge.net, jack@suse.cz,
	linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from cicero2.cybercity.dk ([212.242.40.53]:51276 "EHLO
	cicero2.cybercity.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759058AbYBET0G (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 5 Feb 2008 14:26:06 -0500
In-Reply-To: <1202233464.12188.43.camel@localhost.localdomain>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> +static struct dentry *udf_fh_to_parent(struct super_block *sb,
> +				       struct fid *fid, int fh_len, int fh_type)
> +{
> +	if (fh_len != 5 || fh_type != FILEID_UDF_WITHOUT_PARENT)
                                                   ^^^^^^^

Argh - this should have been WITH so the line reads:

if (fh_len != 5 || fh_type != FILEID_UDF_WITH_PARENT)

I'll just hold back a little reposting a new patch if other comments
should happen to show up.