From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMZ1G-0006vg-MN for mharc-grub-devel@gnu.org; Tue, 05 Feb 2008 20:24:10 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMZ1E-0006vP-Uq for grub-devel@gnu.org; Tue, 05 Feb 2008 20:24:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMZ1B-0006un-H1 for grub-devel@gnu.org; Tue, 05 Feb 2008 20:24:07 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMZ1B-0006uk-BT for grub-devel@gnu.org; Tue, 05 Feb 2008 20:24:05 -0500 Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JMZ1A-0005PJ-LS for grub-devel@gnu.org; Tue, 05 Feb 2008 20:24:05 -0500 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JMZ12-0006kn-Kc for grub-devel@gnu.org; Wed, 06 Feb 2008 01:23:56 +0000 Received: from adsl-69-234-233-149.dsl.irvnca.pacbell.net ([69.234.233.149]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Feb 2008 01:23:56 +0000 Received: from wa1ter by adsl-69-234-233-149.dsl.irvnca.pacbell.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Feb 2008 01:23:56 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: grub-devel@gnu.org From: walt Date: Tue, 05 Feb 2008 17:23:44 -0800 Organization: gmane Message-ID: <1202261023.460.4.camel@k9.localnet> References: <20080203163933.GJ1756@kirkkit.kollasch.net> <20080205202322.GL1756@kirkkit.kollasch.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-BbiKxABCgbUH9TKHvFTl" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: adsl-69-234-233-149.dsl.irvnca.pacbell.net In-Reply-To: <20080205202322.GL1756@kirkkit.kollasch.net> X-Mailer: Evolution 2.12.3nb1 Sender: news X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: multiboot2 vs. grub2 implementation X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2008 01:24:09 -0000 --=-BbiKxABCgbUH9TKHvFTl Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, 2008-02-05 at 14:23 -0600, jakllsch@kollasch.net wrote: > On Sun, Feb 03, 2008 at 09:11:23AM -0800, walt wrote: > > jakllsch@kollasch.net wrote: > >> Hi, > >> > >> In the course of actually trying to use the MultibootDraft, I've > >> discovered > >> some places where the draft and the grub2 implementation differ... > > > > Hi Jonathan, > > > > Are you using grub2/cvs with or without Bean's latest multiboot patch? > > I tend not to be aware of these things. I'm using stock sources. > > > It still hasn't been committed, and I was about to ask about it anyway. > > Without that patch, multiboot doesn't work. > > Hmm. Agreed :o) Bean's patch had some whitespace corruption anyway, so here it is again, diffed against today's latest cvs grub2: ======================================================================== this is the patch, problems found: 1, the mbi structure is not initialized to all zeros, this means some important member, like mods_count, will contain trash. 2, the entry point in the header is virtual address, we need to translate it to physical address. * loader/i386/pc/multiboot.c (grub_multiboot_load_elf32): Get physical address of entry. (grub_multiboot_load_elf64): Likewise. (grub_multiboot): Initialize mbi structure. --=-BbiKxABCgbUH9TKHvFTl Content-Disposition: attachment; filename=multiboot.patch Content-Type: text/x-patch; name=multiboot.patch; charset=us-ascii Content-Transfer-Encoding: base64 SW5kZXg6IGxvYWRlci9pMzg2L3BjL211bHRpYm9vdC5jDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTog L3NvdXJjZXMvZ3J1Yi9ncnViMi9sb2FkZXIvaTM4Ni9wYy9tdWx0aWJvb3QuYyx2DQpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMTUNCmRpZmYgLXUgLXIxLjE1IG11bHRpYm9vdC5jDQotLS0gbG9hZGVy L2kzODYvcGMvbXVsdGlib290LmMJMiBKYW4gMjAwOCAxMTo1NToyMyAtMDAwMAkxLjE1DQorKysg bG9hZGVyL2kzODYvcGMvbXVsdGlib290LmMJNiBGZWIgMjAwOCAwMToxNjoyNiAtMDAwMA0KQEAg LTk2LDYgKzk2LDcgQEANCiB7DQogICBFbGYzMl9FaGRyICplaGRyID0gKEVsZjMyX0VoZHIgKikg YnVmZmVyOw0KICAgRWxmMzJfUGhkciAqcGhkcjsNCisgIGdydWJfYWRkcl90IHJlYWxfZW50cnkg PSAwOw0KICAgaW50IGk7DQogDQogICBpZiAoZWhkci0+ZV9pZGVudFtFSV9DTEFTU10gIT0gRUxG Q0xBU1MzMikNCkBAIC0xNDQsOSArMTQ1LDE2IEBADQogICAgICAgICAgIGlmIChwaGRyLT5wX2Zp bGVzeiA8IHBoZHItPnBfbWVtc3opDQogICAgICAgICAgICAgZ3J1Yl9tZW1zZXQgKChjaGFyICop IHBoZHItPnBfcGFkZHIgKyBwaGRyLT5wX2ZpbGVzeiwgMCwNCiAJCQkgcGhkci0+cF9tZW1zeiAt IHBoZHItPnBfZmlsZXN6KTsNCisNCisgICAgICAgICAgaWYgKChlbnRyeSA+PSBwaGRyLT5wX3Zh ZGRyKSAmJg0KKwkgICAgICAoZW50cnkgPCBwaGRyLT5wX3ZhZGRyICsgcGhkci0+cF9tZW1zeikp DQorCSAgICByZWFsX2VudHJ5ID0gZW50cnkgKyBwaGRyLT5wX3BhZGRyIC0gcGhkci0+cF92YWRk cjsNCiAgICAgICAgIH0NCiAgICAgfQ0KLSAgDQorDQorICBpZiAocmVhbF9lbnRyeSkNCisgICAg ZW50cnkgPSByZWFsX2VudHJ5Ow0KKw0KICAgcmV0dXJuIGdydWJfZXJybm87DQogfQ0KIA0KQEAg LTE2NCw2ICsxNzIsNyBAQA0KIHsNCiAgIEVsZjY0X0VoZHIgKmVoZHIgPSAoRWxmNjRfRWhkciAq KSBidWZmZXI7DQogICBFbGY2NF9QaGRyICpwaGRyOw0KKyAgZ3J1Yl9hZGRyX3QgcmVhbF9lbnRy eSA9IDA7DQogICBpbnQgaTsNCiANCiAgIGlmIChlaGRyLT5lX2lkZW50W0VJX0NMQVNTXSAhPSBF TEZDTEFTUzY0KQ0KQEAgLTIyNiw5ICsyMzUsMTYgQEANCiAJCQkgICsgcGhkci0+cF9maWxlc3op LA0KIAkJCSAwLA0KIAkJCSBwaGRyLT5wX21lbXN6IC0gcGhkci0+cF9maWxlc3opOw0KKw0KKwkg IGlmICgoZW50cnkgPj0gcGhkci0+cF92YWRkcikgJiYNCisJICAgICAgKGVudHJ5IDwgcGhkci0+ cF92YWRkciArIHBoZHItPnBfbWVtc3opKQ0KKwkgICAgcmVhbF9lbnRyeSA9IGVudHJ5ICsgcGhk ci0+cF9wYWRkciAtIHBoZHItPnBfdmFkZHI7DQogICAgICAgICB9DQogICAgIH0NCi0gIA0KKw0K KyAgaWYgKHJlYWxfZW50cnkpDQorICAgIGVudHJ5ID0gcmVhbF9lbnRyeTsNCisNCiAgIHJldHVy biBncnViX2Vycm5vOw0KIH0NCiANCkBAIC0zMDYsNiArMzIyLDggQEANCiAgIGlmICghIG1iaSkN CiAgICAgZ290byBmYWlsOw0KIA0KKyAgZ3J1Yl9tZW1zZXQgKG1iaSwgMCwgc2l6ZW9mIChzdHJ1 Y3QgZ3J1Yl9tdWx0aWJvb3RfaW5mbykpOw0KKw0KICAgbWJpLT5mbGFncyA9IE1VTFRJQk9PVF9J TkZPX01FTU9SWTsNCiANCiAgIC8qIENvbnZlcnQgZnJvbSBieXRlcyB0byBraWxvYnl0ZXMuICAq Lw0K --=-BbiKxABCgbUH9TKHvFTl--