From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 08/13] o11s: other changes in mac80211 for mesh interface support
Date: Fri, 08 Feb 2008 16:42:28 -0800 [thread overview]
Message-ID: <1202517748.7025.40.camel@localhost> (raw)
In-Reply-To: <1202346343.9965.88.camel@johannes.berg>
On Thu, 2008-02-07 at 02:05 +0100, Johannes Berg wrote:
> > +int ieee80211_get_mesh_hdrlen(struct ieee80211s_hdr *meshhdr)
> > +{
> > + int ae = meshhdr->flags & IEEE80211S_FLAGS_AE;
> > + /* 7.1.3.5a.2 */
> > + switch (ae) {
> > + case 0:
> > + return 5;
> > + case 1:
> > + return 11;
> > + case 2:
> > + return 17;
> > + case 3:
> > + return 23;
> > + default:
> > + return 5;
> > + }
> > +}
>
> What the hell? This is utterly horrible! Can that be changed in the spec
> so the header is always a multiple of four bytes? :)
Well it actually can be changed as it is still a draft... Guess you just
need to convince a few hardware manufacturers that the change is in
their interest..
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
prev parent reply other threads:[~2008-02-09 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 19:22 [PATCH 08/13] o11s: other changes in mac80211 for mesh interface support Luis Carlos Cobo
2008-02-07 1:05 ` Johannes Berg
2008-02-09 0:42 ` Luis Carlos Cobo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202517748.7025.40.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.