From: Joe Perches <joe@perches.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Roman Zippel <zippel@linux-m68k.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] affs: fix shadowed variable sparse warnings
Date: Fri, 08 Feb 2008 19:01:24 -0800 [thread overview]
Message-ID: <1202526084.6113.6.camel@localhost> (raw)
In-Reply-To: <1202525599.8067.11.camel@brick>
On Fri, 2008-02-08 at 18:53 -0800, Harvey Harrison wrote:
> diff --git a/fs/affs/file.c b/fs/affs/file.c
> index 6e0c939..ac05dc2 100644
> --- a/fs/affs/file.c
> +++ b/fs/affs/file.c
> @@ -570,11 +570,11 @@ affs_extent_file_ofs(struct inode *inode, u32 newsize)
> bh->b_state &= ~(1UL << BH_New);
> mark_buffer_dirty_inode(bh, inode);
> if (prev_bh) {
> - u32 tmp = be32_to_cpu(AFFS_DATA_HEAD(prev_bh)->next);
> - if (tmp)
> - affs_warning(sb, "extent_file_ofs", "next block already set for %d (%d)", bidx, tmp);
> + u32 _tmp = be32_to_cpu(AFFS_DATA_HEAD(prev_bh)->next);
Perhaps u32 next = be32_to_cpu(AFFS_DATA_HEAD(prev_bh)->next);
prev parent reply other threads:[~2008-02-09 3:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 2:53 [PATCH] affs: fix shadowed variable sparse warnings Harvey Harrison
2008-02-09 3:01 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202526084.6113.6.camel@localhost \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.