Re: [Bluez-devel] [PATCH] Simplify about dialog code

[Marcel Holtmann <marcel@holtmann.org>]

Hi Jaap,

> > > > Before you're holidays I sent you a patch which simplifies the about
> > > > dialog code. We went on discussing it but didn't come to a conclusion,
> > > > I think
> > >
> > > I am not going on holidays. At least not that I know of :)
> > >
> > > > In my opinion it's a good patch because:
> > > >
> > > > 1) The patch removes about 20 function calls
> > > > 2) You don't need  to hookup signals to the about dialog
> > > > 3) Eog, cheese, gnome-power-manager, nautilus, gedit to name a few all
> > > > do it this way.
> > >
> > > Still not convinced.
> >
> > Using gtk_dialog_run() means that you're running the main loop from the
> > about box code. Fixing this would add code. The patch Jaap sent removes
> > a lot of code, and avoids things like double-about boxes, or crappy
> > backtraces that show the about box callback function :)
>
> The patch even fixes bugs. So that should be enough reason to apply it, right?
> Otherwise I'm interested in hearing your arguments against it.

this is the first time that I hear it actually fixes bugs (maybe I
wasn't listen earlier), but actually you have to explain it. Telling me
that it fixes bugs (that I am not aware of) isn't enough. Show me the
bug and how it fixes it and it is highly likely that I simply go ahead
and apply your patch.

Btw. I did a new release and forgot to check if the patch would still
apply. If not, care to redo it.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel