All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] Make search button (and discovery) work
Date: Tue, 12 Feb 2008 01:12:00 +0100	[thread overview]
Message-ID: <1202775120.7664.205.camel@violet> (raw)
In-Reply-To: <1202773661.3491.187.camel@cookie.hadess.net>

Hi Bastien,

> > > > > Seems that some bits of client.c got mistakenly commented. The #endif
> > > > > should be before the call to DiscoverDevices, not after.
> > > > > 
> > > > > So I fixed this up and finished the work to make the search button
> > > > > behave as expected. I guess we should have it by default now.
> > > > 
> > > > where do you need the extra marshal entry for?
> > > 
> > > For the client.c signal changes in bluetooth_client_class_init().
> > 
> > patch has been applied, but I removed the two g_message calls.
> 
> I forgot to mention those were there for debugging, and that they should
> be removed before commit. I hope they were at least useful for your
> testing :)

just fixed a signal issue with it. Noticed only after the 0.19 release.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

      reply	other threads:[~2008-02-12  0:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 17:30 [Bluez-devel] [PATCH] Make search button (and discovery) work Bastien Nocera
2008-02-11 17:50 ` Marcel Holtmann
2008-02-11 17:52   ` Bastien Nocera
2008-02-11 22:25     ` Marcel Holtmann
2008-02-11 23:47       ` Bastien Nocera
2008-02-12  0:12         ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202775120.7664.205.camel@violet \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.