From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JP41z-0002um-Qi for mharc-grub-devel@gnu.org; Tue, 12 Feb 2008 17:55:15 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JP41x-0002uQ-ES for grub-devel@gnu.org; Tue, 12 Feb 2008 17:55:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JP41v-0002uA-U0 for grub-devel@gnu.org; Tue, 12 Feb 2008 17:55:13 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JP41v-0002u7-PE for grub-devel@gnu.org; Tue, 12 Feb 2008 17:55:11 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1JP41v-0003rC-Cr for grub-devel@gnu.org; Tue, 12 Feb 2008 17:55:11 -0500 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 12 Feb 2008 17:55:11 -0500 Received: from [192.168.1.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 9E0EF619058 for ; Tue, 12 Feb 2008 17:55:10 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080212114709.GC19144@thorin> References: <1202805123.5459.23.camel@solid.paris.klabs.be> <20080212114709.GC19144@thorin> Content-Type: text/plain Date: Tue, 12 Feb 2008 17:55:10 -0500 Message-Id: <1202856910.20992.30.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: comments about /etc/default/grub X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2008 22:55:14 -0000 On Tue, 2008-02-12 at 12:47 +0100, Robert Millan wrote: > I suppose a distro-agnostic template should really be added, but I > didn't > find an ellegant way to solve the GRUB_DISTRIBUTOR "problem". > > For other reasons, I was thinking in a directory (let's call it > /etc/grub.source.d/) where add-ons are sourced rather than executed. Let's use the same grub.d (in /usr/local/etc for local install and in /etc for system install). What we need is a site template and a vendor template. I think the templates should be sourced before 00_header. Maybe the numbers should be shifted, so that we have 10_site, 20_vendor, 30_header etc and still have gaps for more stuff. Or the templates should have a distinctive suffix. The assignments should be careful to preserve already set variables. The assignments should be written like this: : ${GRUB_CMDLINE_LINUX=foo=bar quux=1} In some cases, appending more stuff would be preferred, but for GRUB_CMDLINE_LINUX, it's better to allow the earlier templates or the environment to cancel the additions. The site template could be installed unless it's installed already. Or it could be installed under a name under which it won't be sourced, and should have an explanation how to rename it to make it work. -- Regards, Pavel Roskin