From: Harvey Harrison <harvey.harrison@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: include prototype for no_broadcast in mach-default/setup.c
Date: Wed, 13 Feb 2008 09:34:06 -0800 [thread overview]
Message-ID: <1202924047.9824.14.camel@brick> (raw)
In-Reply-To: <20080213104227.GC32241@elte.hu>
On Wed, 2008-02-13 at 11:42 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > Fixes sparse warning:
> > arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not declared. Should it be static?
>
> hm, this patch causes a build failure:
>
> In file included from arch/x86/mach-default/setup.c:13:
> include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_allbutself':
> include/asm/mach-default/mach_ipi.h:25: error: 'APIC_DEST_ALLBUT' undeclared (first use in this function)
> include/asm/mach-default/mach_ipi.h:25: error: (Each undeclared identifier is reported only once
> include/asm/mach-default/mach_ipi.h:25: error: for each function it appears in.)include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_all':
> include/asm/mach-default/mach_ipi.h:33: error: 'APIC_DEST_ALLINC' undeclared (first use in this function)
>
> config attached. The include file dependencies in this area are a bit of
> a mess - perhaps they need some cleanups?
OK, I'm building all(yes|mod)configs and didn't see this. Agreed about
the file dependencies here, I'll take a look. If you have any notes
lying around, would appreciate the head-start.
Harvey
next prev parent reply other threads:[~2008-02-13 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 20:35 [PATCH] x86: include prototype for no_broadcast in mach-default/setup.c Harvey Harrison
2008-02-13 10:42 ` Ingo Molnar
2008-02-13 17:34 ` Harvey Harrison [this message]
2008-02-17 20:09 ` Ingo Molnar
2008-02-17 21:36 ` Harvey Harrison
2008-02-16 18:30 ` Thomas Gleixner
2008-02-17 14:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202924047.9824.14.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.