From: Harvey Harrison <harvey.harrison@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>,
Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [RFC-PATCH] fuse: shadowed variable warning
Date: Fri, 15 Feb 2008 10:58:22 -0800 [thread overview]
Message-ID: <1203101902.15275.25.camel@brick> (raw)
fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier one
fs/fuse/dir.c:893:6: originally declared here
This means that an error between lines 909 and 923 will not be
returned.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Miklos, could you confirm whether or not you want the err from lines
909-923 returned or not. If so, I can respin this patch changing the
variable name instead which would preserve the current behavior.
This patch changes behavior.
fs/fuse/dir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 7fb514b..c4807b3 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -906,7 +906,7 @@ static int fuse_permission(struct inode *inode, int mask, struct nameidata *nd)
}
if (fc->flags & FUSE_DEFAULT_PERMISSIONS) {
- int err = generic_permission(inode, mask, NULL);
+ err = generic_permission(inode, mask, NULL);
/* If permission is denied, try to refresh file
attributes. This is also needed, because the root
--
1.5.4.1.1278.gc75be
next reply other threads:[~2008-02-15 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 18:58 Harvey Harrison [this message]
2008-02-15 19:13 ` [RFC-PATCH] fuse: shadowed variable warning Miklos Szeredi
2008-02-15 19:40 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203101902.15275.25.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.