All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: git@vger.kernel.org
Cc: Jay Soffian <jaysoffian@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time
Date: Fri, 15 Feb 2008 16:53:36 -0500	[thread overview]
Message-ID: <1203112418-25199-1-git-send-email-jaysoffian@gmail.com> (raw)
In-Reply-To: 1203042077-11385-1-git-send-email-jaysoffian@gmail.com

handle_filter() is only supposed to get one line at a time.
handle_body() already ensures this after decoding BASE64 messages per
this comment:

/* this is a decoded line that may contain
 * multiple new lines.  Pass only one chunk
 * at a time to handle_filter()
 */

QP messages need to be similarly processed since decoding QP can also
add newlines.

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
I broke this change out into it's own patch since it's independent of
the format=flowed additions.

 builtin-mailinfo.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
index 2600847..11f154b 100644
--- a/builtin-mailinfo.c
+++ b/builtin-mailinfo.c
@@ -818,6 +818,7 @@ static void handle_body(void)
 
 		switch (transfer_encoding) {
 		case TE_BASE64:
+		case TE_QP:
 		{
 			char *op = line;
 
-- 
1.5.4.1.1281.g75df

             reply	other threads:[~2008-02-15 21:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 21:53 Jay Soffian [this message]
2008-02-15 21:53 ` [PATCH 2/3] mailinfo: support rfc3676 (format=flowed) text/plain messages Jay Soffian
2008-02-15 21:53   ` [PATCH 3/3] test mailinfo rfc3676 support Jay Soffian
2008-02-15 23:24 ` [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time Junio C Hamano
2008-02-15 23:37   ` Jay Soffian
2008-02-16  6:17     ` Junio C Hamano
2008-02-16  6:22       ` Junio C Hamano
2008-02-16  6:51       ` Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203112418-25199-1-git-send-email-jaysoffian@gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.