From: Pavel Roskin <proski@gnu.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
bruno randolf <br1@einfach.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: fix IBSS code
Date: Thu, 21 Feb 2008 13:27:36 -0500 [thread overview]
Message-ID: <1203618456.2141.9.camel@dv> (raw)
In-Reply-To: <20080221173224.GJ3094@tuxdriver.com>
On Thu, 2008-02-21 at 12:32 -0500, John W. Linville wrote:
> On Thu, Feb 21, 2008 at 12:16:02PM -0500, Pavel Roskin wrote:
> > On Thu, 2008-02-21 at 11:08 +0100, Johannes Berg wrote:
> > > - if (CONFIG_MAC80211_IBSS_DEBUG || net_ratelimit())
> > > +#ifndef CONFIG_MAC80211_IBSS_DEBUG
> > > + if (net_ratelimit())
> > > +#endif
> >
> > It looks like you did a better job at guessing the intention of the code
> > than me.
> >
> > Please apply this patch, not mine.
>
> Hmmm...maybe you are right. Unfortunately I already apply your
> patch instead.
I don't really care. It's just a KERN_DEBUG message after all. I see
no problems with using net_ratelimit() in all cases. And I don't see
any strong need to suppress this message. I don't expect it will happen
often. But I'm not the one who will be looking at the logs :)
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2008-02-21 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 10:08 [PATCH] mac80211: fix IBSS code Johannes Berg
2008-02-21 17:07 ` John W. Linville
2008-02-21 19:23 ` Johannes Berg
2008-02-21 19:43 ` John W. Linville
2008-02-22 0:51 ` bruno randolf
2008-02-21 17:16 ` Pavel Roskin
2008-02-21 17:32 ` John W. Linville
2008-02-21 18:27 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203618456.2141.9.camel@dv \
--to=proski@gnu.org \
--cc=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.