From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH 5/5] [POWERPC] Add 460EX PCIe support to 4xx pci driver
Date: Sun, 24 Feb 2008 07:46:48 +1100 [thread overview]
Message-ID: <1203799608.6976.44.camel@pasglop> (raw)
In-Reply-To: <18367.34338.962846.402664@cargo.ozlabs.ibm.com>
On Sat, 2008-02-23 at 13:34 +1100, Paul Mackerras wrote:
> Stefan Roese writes:
>
> > Tested on AMCC Canyonlands eval board.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
>
> With 173 lines of code added, you could spend a paragraph in the patch
> description telling us why the patch is doing what it's doing the way
> it's doing it. Perhaps even tell us why it takes 173 new lines of
> code to do something that sounds pretty simple - tell us what the
> complexities you encountered were.
Actually, the patch just adds a backend to my little framework for
dealing with 4xx PCIe, which basically is a boring piece of code
filling registers with values mostly from the spec... nothing really
fancy there.
Cheers,
Ben.
next prev parent reply other threads:[~2008-02-23 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 14:01 [PATCH 5/5] [POWERPC] Add 460EX PCIe support to 4xx pci driver Stefan Roese
2008-02-23 2:34 ` Paul Mackerras
2008-02-23 20:46 ` Benjamin Herrenschmidt [this message]
2008-02-23 22:39 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203799608.6976.44.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.