From: Joe Perches <joe@perches.com>
To: Hawkes Steve-FSH016 <Steve.Hawkes@motorola.com>
Cc: David Miller <davem@davemloft.net>, LKML <linux-kernel@vger.kernel.org>
Subject: RE: printk_ratelimit and net_ratelimit conflict and tunable behavior
Date: Mon, 25 Feb 2008 16:04:38 -0800 [thread overview]
Message-ID: <1203984278.19319.312.camel@localhost> (raw)
In-Reply-To: <7BFDACCD6948EF4D8FE8F4888A91596A016371FE@tx14exm60.ds.mot.com>
On Mon, 2008-02-25 at 17:49 -0600, Hawkes Steve-FSH016 wrote:
> Are you saying the few lines of code to handle changes to the tunables
> aren't worth keeping?
Yes.
I think the tunables, if needed at all, should be set by modifying
the struct and the call might as well be:
bool __printk_ratelimit(struct printk_ratelimit_state *state)
Another quibble is not directed to your change because it's
preexisting but "tok" isn't a good name and may not even need
to be in the structure. It does save a multiply though.
I think that anything that attempts a printk is slow path
so it doesn't matter much though.
next prev parent reply other threads:[~2008-02-26 0:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 21:30 printk_ratelimit and net_ratelimit conflict and tunable behavior Hawkes Steve-FSH016
2008-02-21 6:32 ` David Miller
2008-02-21 7:00 ` Joe Perches
2008-02-25 15:47 ` Hawkes Steve-FSH016
2008-02-25 20:02 ` David Miller
2008-02-25 20:13 ` Joe Perches
[not found] ` <7BFDACCD6948EF4D8FE8F4888A91596A016371FE@tx14exm60.ds.mot.com>
2008-02-26 0:04 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-25 20:36 Steven Hawkes
2008-02-25 23:45 ` Andrew Morton
2008-02-28 16:19 ` Hawkes Steve-FSH016
2008-02-28 18:39 ` Andrew Morton
2008-02-28 16:10 Steven Hawkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203984278.19319.312.camel@localhost \
--to=joe@perches.com \
--cc=Steve.Hawkes@motorola.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.