From: Joe Perches <joe@perches.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <matthew@wil.cx>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros
Date: Tue, 26 Feb 2008 20:02:27 -0800 [thread overview]
Message-ID: <1204084947.19319.411.camel@localhost> (raw)
In-Reply-To: <1204081722.19319.405.camel@localhost>
Converting inline __attribute__((format (printf,x,y) functions
to macros or statement expressions produces smaller objects
before:
$ size vmlinux
text data bss dec hex filename
4716770 474560 618496 5809826 58a6a2 vmlinux
after:
$ size vmlinux
text data bss dec hex filename
4716706 474560 618496 5809762 58a662 vmlinux
Signed-off-by: Joe Perches <joe@perches.com>
include/linux/fs.h | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index b84b848..a0ba590 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2055,11 +2055,10 @@ static struct file_operations __fops = { \
.write = simple_attr_write, \
};
-static inline void __attribute__((format(printf, 1, 2)))
-__simple_attr_check_format(const char *fmt, ...)
-{
- /* don't do anything, just let the compiler check the arguments; */
-}
+/* don't do anything, just let the compiler check the arguments; */
+
+#define __simple_attr_check_format(fmt, args...) \
+ do { if (0) printk(fmt, ##args); } while (0)
int simple_attr_open(struct inode *inode, struct file *file,
int (*get)(void *, u64 *), int (*set)(void *, u64),
next prev parent reply other threads:[~2008-02-27 4:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 3:08 [PATCH] linux/kernel.h linux/device.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros Joe Perches
2008-02-27 4:02 ` Joe Perches [this message]
2008-02-27 4:13 ` [PATCH] linux/fs.h " Matthew Wilcox
2008-02-27 4:55 ` Joe Perches
2008-02-27 5:44 ` David Rientjes
2008-02-27 5:44 ` David Rientjes
2008-02-27 6:54 ` Joe Perches
2008-02-27 7:38 ` David Rientjes
2008-02-27 7:38 ` David Rientjes
2008-02-27 22:58 ` David Rientjes
2008-02-27 22:58 ` David Rientjes
2008-02-27 23:58 ` Jan Hubicka
2008-02-28 8:28 ` David Rientjes
2008-02-28 8:28 ` David Rientjes
2008-02-28 8:42 ` Jakub Jelinek
2008-02-28 10:23 ` Jan Hubicka
2008-02-29 1:09 ` Joe Perches
2008-02-29 1:09 ` Joe Perches
2008-03-23 15:22 ` Denys Vlasenko
2008-03-24 19:52 ` Joe Perches
2008-03-24 19:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204084947.19319.411.camel@localhost \
--to=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.