All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillaume Bedot <littletux@zarb.org>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [Bluez-devel] forcing SCO connection patch
Date: Wed, 27 Feb 2008 14:04:42 +0100	[thread overview]
Message-ID: <1204117482.6889.37.camel@localhost> (raw)
In-Reply-To: <47C555E5.2000903@mizi.com>

Re,

Le mercredi 27 février 2008 à 21:21 +0900, Louis JANG a écrit :
>  	conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->bdaddr);
> -	if (!conn)
> -		goto unlock;
> +	if (!conn) {
> +		__u8 link_type = (ev->link_type == ESCO_LINK) ? SCO_LINK : ESCO_LINK;
> +
> +		conn = hci_conn_hash_lookup_ba(hdev, link_type, &ev->bdaddr);
> +		if (!conn)
> +			goto unlock;

Does your patch handle re-negotiation of the SCO link back to an eSCO
one ? Great.

And the style in your patch is better according to Marcel rules.

I vote for yours.

Best regards,

Guillaume B.


  reply	other threads:[~2008-02-27 13:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 12:39 [Bluez-devel] forcing SCO connection patch Louis JANG
2008-02-25  6:43 ` Brad Midgley
2008-02-25  6:56   ` Brad Midgley
2008-02-26 19:19   ` Guillaume Bedot
2008-02-26 19:28     ` Marcel Holtmann
2008-02-26 21:05       ` Guillaume Bedot
2008-02-25  7:30 ` Dave Young
2008-02-25  7:34   ` Dave Young
2008-02-25  8:26     ` Dave Young
2008-02-25  8:26       ` Dave Young
2008-02-25  9:28   ` Louis JANG
2008-02-25  9:55     ` Dave Young
2008-02-25  9:55       ` Dave Young
2008-02-25 11:35       ` Louis JANG
2008-02-25 11:35         ` Louis JANG
2008-02-26  3:07         ` Marcel Holtmann
2008-02-26  3:07           ` Marcel Holtmann
2008-02-26  3:53           ` Louis JANG
2008-02-26 19:43             ` Marcel Holtmann
2008-02-26 19:43               ` Marcel Holtmann
2008-02-27  1:58               ` Louis JANG
2008-02-27  1:58                 ` Louis JANG
2008-02-27  9:57                 ` Marcel Holtmann
2008-02-27 12:21                   ` Louis JANG
2008-02-27 13:04                     ` Guillaume Bedot [this message]
2008-02-27 15:21                     ` Marcel Holtmann
2008-02-27 15:21                       ` Marcel Holtmann
2008-02-28  2:49                       ` Louis JANG
2008-02-28  2:49                         ` Louis JANG
2008-02-28 10:57                         ` Guillaume Bedot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204117482.6889.37.camel@localhost \
    --to=littletux@zarb.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.