All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/4 net-2.6.26] [IPV4]: Cleanup ip_options_compile.
Date: Mon, 03 Mar 2008 23:54:58 +0300	[thread overview]
Message-ID: <1204577698.23504.13.camel@iris.sw.ru> (raw)
In-Reply-To: <20080303.115509.71743609.davem@davemloft.net>

On Mon, 2008-03-03 at 11:55 -0800, David Miller wrote:
> From: "Denis V. Lunev" <den@openvz.org>
> Date: Mon,  3 Mar 2008 18:48:41 +0300
> 
> > Right now ip_options_compile is called twice as (NULL, skb) and (opt, NULL).
> > So, let's move opt initialization into caller and remove this initialization
> > branch.
> > 
> > Additionally, the field ip_options->is_data becomes not needed. All decisions
> > should be made by the real skb availability.
> > 
> > Signed-off-by: Denis V. Lunev <den@openvz.org>
> 
> I don't think this "is_data" elimination works.
> 
> Sometimes these option blobs come from the user or elsewhere.  And
> that's why we have to sometimes use opt->__data instead of the SKB
> embedded blob.
> 
> You also missed the is_data case in cipso_ipv4.c, so this wouldn't
> even compile.  Is there something wrong with "git grep" on your
> computer?

thanks for pointing this out.

Though, it seems to me, that this structure does not came from
userspace. At least I do not see a way for this. Could you show me how
this can happen?


  reply	other threads:[~2008-03-03 20:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03 15:48 [PATCH 1/4 net-2.6.26] [IPV4]: skb->dst can't be NULL in ip_options_echo Denis V. Lunev
2008-03-03 15:48 ` [PATCH 2/4 net-2.6.26] [IPV4]: Cleanup ip_options_compile Denis V. Lunev
2008-03-03 19:55   ` David Miller
2008-03-03 20:54     ` Denis V. Lunev [this message]
2008-03-03 21:24       ` David Miller
2008-03-03 22:57         ` Denis V. Lunev
2008-03-03 23:02           ` David Miller
2008-03-03 15:48 ` [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning Denis V. Lunev
2008-03-03 17:39   ` YOSHIFUJI Hideaki / 吉藤英明
2008-03-03 17:53     ` [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning. (fixed) Denis V. Lunev
2008-03-03 19:56       ` David Miller
2008-03-03 18:41     ` [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning Vlad Yasevich
2008-03-03 15:48 ` [PATCH 4/4 net-2.6.26] [TCP]: Merge exit paths in tcp_v4_conn_request Denis V. Lunev
2008-03-03 19:59   ` David Miller
2008-03-03 19:50 ` [PATCH 1/4 net-2.6.26] [IPV4]: skb->dst can't be NULL in ip_options_echo David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204577698.23504.13.camel@iris.sw.ru \
    --to=den@openvz.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.