From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/14] drivers/s390: replace remaining __FUNCTION__ occurrences
Date: Tue, 04 Mar 2008 09:55:07 +0100 [thread overview]
Message-ID: <1204620907.1278.7.camel@localhost> (raw)
In-Reply-To: <1204600187.22933.86.camel@brick>
On Mon, 2008-03-03 at 19:09 -0800, Harvey Harrison wrote:
> __FUNCTION__ is gcc-specific, use __func__
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/s390/block/dasd.c | 4 +-
> drivers/s390/char/tape_34xx.c | 2 +-
> drivers/s390/char/vmwatchdog.c | 4 +-
> drivers/s390/char/zcore.c | 2 +-
> drivers/s390/cio/device_status.c | 2 +-
> drivers/s390/crypto/zcrypt_api.h | 8 +-
> drivers/s390/net/claw.c | 344 +++++++++++++++++++-------------------
> drivers/s390/net/ctcmain.c | 112 ++++++------
> drivers/s390/net/netiucv.c | 96 ++++++------
> drivers/s390/s390mach.c | 8 +-
> drivers/s390/scsi/zfcp_def.h | 2 +-
> 11 files changed, 292 insertions(+), 292 deletions(-)
Urgh, is this really necessary? The linux kernel is always compiled with
gcc for s390. Yes __func__ is a bit shorter and maybe even looks nicer
than __FUNCTION__ but is it really worth the trouble ?
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2008-03-04 8:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ff8fd021606e7a6f03e9c274230cfcf64eade6d2.1204599636.git.harvey.harrison@gmail.com>
2008-03-04 3:09 ` [PATCH 02/14] drivers/char: replace remaining __FUNCTION__ occurrences Harvey Harrison
2008-03-04 3:09 ` [PATCH 03/14] input: " Harvey Harrison
2008-03-04 3:09 ` [PATCH 04/14] i2c: " Harvey Harrison
2008-03-04 9:12 ` Jean Delvare
2008-03-04 3:09 ` [PATCH 05/14] pci: " Harvey Harrison
2008-03-04 3:09 ` [PATCH 06/14] drivers/s390: " Harvey Harrison
2008-03-04 8:55 ` Martin Schwidefsky [this message]
2008-03-04 9:15 ` Andrew Morton
2008-03-04 3:09 ` [PATCH 07/14] isdn: " Harvey Harrison
2008-03-04 3:09 ` [PATCH 08/14] scsi: " Harvey Harrison
2008-03-04 3:30 ` James Bottomley
2008-03-04 3:44 ` Harvey Harrison
2008-03-04 3:09 ` [PATCH 10/14] serial: " Harvey Harrison
2008-03-04 3:09 ` [PATCH 09/14] ide: " Harvey Harrison
2008-03-04 21:25 ` Bartlomiej Zolnierkiewicz
2008-03-04 3:09 ` [PATCH 11/14] drivers/parisc: " Harvey Harrison
2008-03-04 3:09 ` [PATCH 12/14] video: " Harvey Harrison
2008-03-04 3:09 ` [PATCH 13/14] rtc: " Harvey Harrison
2008-03-04 3:09 ` [PATCH 14/14] fusion: " Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204620907.1278.7.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.