diff for duplicates of <1204700995.17484.7.camel@brick> diff --git a/a/1.txt b/N1/1.txt index 3acdb95..5a471d6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote: -> * Christopher Li <sparse@chrisli.org> wrote: +> * Christopher Li <sparse-55XgFHCVCFZAfugRpC6u6w@public.gmane.org> wrote: > > > I think Al Viro has sent a patch to linux-sparse with subject "[PATCH > > 3/3] catch !x & y brainos" does exactly that. @@ -10,8 +10,8 @@ On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote: > > Al's patch is: > -> + if (op = '&' && expr->left->type = EXPR_PREOP && -> + expr->left->op = '!') +> + if (op == '&' && expr->left->type == EXPR_PREOP && +> + expr->left->op == '!') > + warning(expr->pos, "dubious: !x & y"); > > i think there might be similar patterns: "x & !y", "!x | y", "x | !y" ? @@ -21,3 +21,8 @@ Well, (!x & y) and (!x | y) are probably the two that might have been intended otherwise. (x & !y), (x | !y) are probably ok. Harvey + +-- +To unsubscribe from this list: send the line "unsubscribe linux-wireless" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 14b9e43..163b186 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,9 +3,9 @@ "ref\070318cbf0803042249j57d7f3a3j7666961a9132b10b@mail.gmail.com\0" "ref\020080305070201.GA32434@elte.hu\0" "ref\020080305070201.GA32434-X9Un+BFzKDI@public.gmane.org\0" - "From\0Harvey Harrison <harvey.harrison@gmail.com>\0" - "Subject\0Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct\0" - "Date\0Wed, 05 Mar 2008 07:09:55 +0000\0" + "From\0Harvey Harrison <harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Subject\0Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and &\0" + "Date\0Tue, 04 Mar 2008 23:09:55 -0800\0" "To\0Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>\0" "Cc\0Christopher Li <sparse-55XgFHCVCFZAfugRpC6u6w@public.gmane.org>" Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org> @@ -20,7 +20,7 @@ "\00:1\0" "b\0" "On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote:\n" - "> * Christopher Li <sparse@chrisli.org> wrote:\n" + "> * Christopher Li <sparse-55XgFHCVCFZAfugRpC6u6w@public.gmane.org> wrote:\n" "> \n" "> > I think Al Viro has sent a patch to linux-sparse with subject \"[PATCH \n" "> > 3/3] catch !x & y brainos\" does exactly that.\n" @@ -31,8 +31,8 @@ "> \n" "> Al's patch is:\n" "> \n" - "> + if (op = '&' && expr->left->type = EXPR_PREOP &&\n" - "> + expr->left->op = '!')\n" + "> + if (op == '&' && expr->left->type == EXPR_PREOP &&\n" + "> + expr->left->op == '!')\n" "> + warning(expr->pos, \"dubious: !x & y\");\n" "> \n" "> i think there might be similar patterns: \"x & !y\", \"!x | y\", \"x | !y\" ?\n" @@ -41,6 +41,11 @@ "Well, (!x & y) and (!x | y) are probably the two that might have been\n" "intended otherwise. (x & !y), (x | !y) are probably ok.\n" "\n" - Harvey + "Harvey\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-wireless\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -06fc13bb5bf6e514e940c56a49cf83efb5c193f874f600c91dbb176116f49a79 +3003c8d1d5f4c8277c46f30b814990908652dc881ca6eb5746898158344712fd
diff --git a/a/1.txt b/N2/1.txt index 3acdb95..3cd263b 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -10,8 +10,8 @@ On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote: > > Al's patch is: > -> + if (op = '&' && expr->left->type = EXPR_PREOP && -> + expr->left->op = '!') +> + if (op == '&' && expr->left->type == EXPR_PREOP && +> + expr->left->op == '!') > + warning(expr->pos, "dubious: !x & y"); > > i think there might be similar patterns: "x & !y", "!x | y", "x | !y" ? diff --git a/a/content_digest b/N2/content_digest index 14b9e43..482ef46 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,21 +2,20 @@ "ref\020080305063842.GA24495@elte.hu\0" "ref\070318cbf0803042249j57d7f3a3j7666961a9132b10b@mail.gmail.com\0" "ref\020080305070201.GA32434@elte.hu\0" - "ref\020080305070201.GA32434-X9Un+BFzKDI@public.gmane.org\0" "From\0Harvey Harrison <harvey.harrison@gmail.com>\0" - "Subject\0Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct\0" - "Date\0Wed, 05 Mar 2008 07:09:55 +0000\0" - "To\0Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>\0" - "Cc\0Christopher Li <sparse-55XgFHCVCFZAfugRpC6u6w@public.gmane.org>" - Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org> - yi.zhu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org - linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - ipw3945-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Alexander Viro <viro-rfM+Q5joDG/XmaaqVzeoHQ@public.gmane.org> - linux-sparse-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " Josh Triplett <josh-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org>\0" + "Subject\0Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and &\0" + "Date\0Tue, 04 Mar 2008 23:09:55 -0800\0" + "To\0Ingo Molnar <mingo@elte.hu>\0" + "Cc\0Christopher Li <sparse@chrisli.org>" + Julia Lawall <julia@diku.dk> + yi.zhu@intel.com + linux-wireless@vger.kernel.org + ipw3945-devel@lists.sourceforge.net + linux-kernel@vger.kernel.org + kernel-janitors@vger.kernel.org + Alexander Viro <viro@ftp.linux.org.uk> + linux-sparse@vger.kernel.org + " Josh Triplett <josh@freedesktop.org>\0" "\00:1\0" "b\0" "On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote:\n" @@ -31,8 +30,8 @@ "> \n" "> Al's patch is:\n" "> \n" - "> + if (op = '&' && expr->left->type = EXPR_PREOP &&\n" - "> + expr->left->op = '!')\n" + "> + if (op == '&' && expr->left->type == EXPR_PREOP &&\n" + "> + expr->left->op == '!')\n" "> + warning(expr->pos, \"dubious: !x & y\");\n" "> \n" "> i think there might be similar patterns: \"x & !y\", \"!x | y\", \"x | !y\" ?\n" @@ -43,4 +42,4 @@ "\n" Harvey -06fc13bb5bf6e514e940c56a49cf83efb5c193f874f600c91dbb176116f49a79 +143a6350be4f81e25f685c409d17565a87038ce074289378cebf4f3b54a6b752
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.